Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update entry point finder to support async Main #75808

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Update entry point finder to support async Main #75808

merged 7 commits into from
Nov 8, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #35376

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 7, 2024 19:10
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 7, 2024
@CyrusNajmabadi
Copy link
Member Author

@akhera99 ptal

akhera99
akhera99 reviewed Nov 8, 2024
View reviewed changes
src/VisualStudio/CSharp/Test/ProjectSystemShim/EntryPointFinderTests.cs Outdated
[CombinatorialValues("void", "int", "System.Int32", "Int32", "ValueTask", "Task", "ValueTask<int>", "Task<int>")] string returnType,
[CombinatorialValues("string[] args", "string[] args1", "")] string parameters)
{
NegativeTest($"{accessibility} {returnType} main({parameters})");
Copy link
Member

@akhera99 akhera99 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Main to be clear it's a "not static" test and not a "wrong name" test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup/ good catch.

@CyrusNajmabadi CyrusNajmabadi merged commit a223dd0 into dotnet:main Nov 8, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the entryPoints branch November 8, 2024 19:03
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 8, 2024
This was referenced Nov 14, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P2
3 participants
@CyrusNajmabadi @akhera99 @jjonescz