Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HasHome out of Binder #75851

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Move HasHome out of Binder #75851

merged 3 commits into from
Nov 12, 2024

Conversation

jjonescz
Copy link
Member

According to #67736 (comment), Binder.HasHome should be used only on lowered nodes, so I'm moving it out of Binder to avoid its misuse. (Prior to the linked PR, the helper was used inside Binder but it's not anymore.)

The first commit does not have any changes except code move.

cc @AlekseyTs

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 11, 2024
@jjonescz jjonescz marked this pull request as ready for review November 11, 2024 14:42
@jjonescz jjonescz requested a review from a team as a code owner November 11, 2024 14:42
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants