Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Copilot powered Inline Rename UX #76001

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Update the Copilot powered Inline Rename UX #76001

merged 11 commits into from
Dec 10, 2024

Conversation

AmadeusW
Copy link
Contributor

@AmadeusW AmadeusW commented Nov 21, 2024 •
edited
Loading

There is a slight delay prior to making Copilot request. Additionally, Roslyn might be gathering references and definition to add semantic context to the prompt.
Our UX designer recommended that we should be showing the progress bar while this is happening.

Before:
roslyn rename progress delay

After:
roslyn rename progress fixed

Additionally, I saw that pressing Ctrl+Space to cancel ongoing request did not work, so I fixed it. In the "before" screenshot, I hit Ctrl+Space to cancel the request, then arrow down to scroll through suggestions, which were not visible
Before:
roslyn rename hidden suggestions

After:
roslyn rename abort fixed

@AmadeusW AmadeusW requested a review from a team as a code owner November 21, 2024 00:13
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 21, 2024
CyrusNajmabadi
CyrusNajmabadi reviewed Dec 3, 2024
View reviewed changes
src/EditorFeatures/Core.Wpf/InlineRename/UI/SmartRename/SmartRenameViewModel.cs Outdated
_cancellationTokenSource = new CancellationTokenSource();
_getSuggestionsTask = GetSuggestionsTaskAsync(isAutomaticOnInitialization, _cancellationTokenSource.Token).CompletesAsyncOperation(listenerToken);
}
}

private async Task GetSuggestionsTaskAsync(bool isAutomaticOnInitialization, CancellationToken cancellationToken)
{
if (isAutomaticOnInitialization)
_threadingContext.ThrowIfNotOnUIThread();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: if thsi is already an async method, don't assert this, use a JTF switch to the actual main thread. it will be a no-op if not on the main thread.

Copy link
Contributor Author

@AmadeusW AmadeusW Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CyrusNajmabadi
Copy link
Member

Ping me tomorrow and I can finish this :-)

@AmadeusW AmadeusW force-pushed the dev/amwieczo/autoRenameUx branch from 5019067 to 2d29d0c Compare December 6, 2024 19:36
@CyrusNajmabadi CyrusNajmabadi merged commit a13d7dc into dotnet:main Dec 10, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 10, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
2 participants
@AmadeusW @CyrusNajmabadi