Honor abstract required during state initialization in nullable #76363
+846
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@RikkiGibson @dotnet/roslyn-compiler for reviews. |
|
It looks like some diagnostics on non-required override properties and events are now missing. |
Fixes dotnet#74423. When we're getting the list of members to default initialize, we look for properties that override `abstract` properties and have nullable annotations that line up with the base ones. For these properties, we can assume that if we chain to a `SetsRequiredMembers` constructor, it took care of setting a non-null state.
333fred
force-pushed
the
required-virtuals
branch
from
7b24880 to
848ec10
Compare
333fred
changed the title
RikkiGibson
reviewed
Dec 12, 2024
RikkiGibson
reviewed
Dec 13, 2024
RikkiGibson
approved these changes
Dec 13, 2024
333fred
changed the title
|
@dotnet/roslyn-compiler for a second review |
|
@333fred Can you think of any VB scenario affected as well? |
VB cannot subclass types with required members, and also does not have NRT, so I do not think it can encounter this issue. |
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74423. When we're enforcing that all members of a type must have non-null values for
SetsRequiredMembers, we don't want to include any members of the current type that are overrides of a base type. Instead, those members should be enforced when we check the chained constructor call, since the chained constructor may itself haveSetsRequiredMembers, and therefore already enforced that overridden properties have a valid state.