Remove TaskQueue and SafeContinueWith extensions #76459
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
requested review from
jasonmalinowski,
JoeRobich and
sharwell
|
@jasonmalinowski @JoeRobich @sharwell @dotnet/roslyn-ide ptal. |
| { | ||
| foreach (var item in list) | ||
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); |
There was a problem hiding this comment.
This cancellation could change behavior here -- before Workspace events would be queued and would continue, at least until the termination of the process. If that cancellation triggers at some earlier point now it might mean people won't get events. Practically, this would only matter during shutdown, and since we were queuing to the UI thread there was already a pretty good chance those might never fire -- there's really no difference between "we cancelled them and they never ran during shutdown" versus "the UI thread was never available during shutdown to run them anyways".
This is probably a small win for shutdown perf; but if we see any strange bugs appear during shutdown this might be a place to investigate. Probably good to see if it's fine, at least!
There was a problem hiding this comment.
yup. i'm very ok with this behavior. you dispose of the workspace, and outstanding work may not happen.
| { | ||
| item(); | ||
| } | ||
| catch (Exception e) when (FatalError.ReportAndCatchUnlessCanceled(e)) |
There was a problem hiding this comment.
Not sure why the "UnlessCancelled" here -- I wouldn't expect cancellation from the action since we never gave it a token.
Fixes #44150
Fixes #47891
Followup to #76455