Remove legacy signature help interaction code. #76495
Merged
+58
−545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
|
@jasonmalinowski ptal. |
CyrusNajmabadi
commented
Dec 18, 2024
| { | ||
| ThreadingContext.ThrowIfNotOnUIThread(); | ||
|
|
||
| var model = ModelTask.WaitAndGetResult(CancellationToken.None); |
There was a problem hiding this comment.
this got rid of another blocking wait, which was the initial reason i was in this space. but i then discovered just how useless all this code is to begin with...
|
@dotnet/roslyn-ide @jasonmalinowski ptal. |
JoeRobich
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform has taken over handling the interaction of sighelp and completion. So the code we have in roslyn to manage this is no longer necessary.
I have also verified the same scenarios manually work. For example: