Disable extract method on pattern matching features #9251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses dotnet#9104 in the following ways: - Fixes the gaps in data flow analysis that were causing the original assert in the bug. - Disables extract method on pattern matching for now. Filed dotnet#9244 to design scenarios here. In order to fill in the data flow gaps I used commit 9d36a64 as a guide. This change removed declaration expressions from the code base and hence gave a good outline of where data flow would be affected by pattern declaration expressions. closes dotnet#9104
|
👍 For the IDE parts. |
|
Compiler parts look good. |
|
👍 for Extract Method changes. |
|
I think that ultimately this behavior should fall out of the standard definite assignment rules for pattern-matching - pattern variables are assigned inside, but not always assigned inside. The fact that it did not work that way out of the box suggests that the region analysis code isn't properly handling the situation. I'll open an issue for it. |
jaredpar
added a commit
that referenced
this pull request
Feb 28, 2016
Disable extract method on pattern matching features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #9104 in the following ways:
In order to fill in the data flow gaps I used commit 9d36a64 as a guide. This change removed declaration expressions from the code base and hence gave a good outline of where data flow would be affected by pattern declaration expressions.
closes #9104