Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RCS1187 #1150

Merged
merged 7 commits into from
Aug 12, 2023
Merged

Fix RCS1187 #1150

merged 7 commits into from
Aug 12, 2023

Conversation

jamesHargreaves12
Copy link
Contributor

@jamesHargreaves12 jamesHargreaves12 commented Aug 6, 2023 •
edited
Loading

Changing a static field to a constant changes the meaning of that symbol in the decorators. For example, applying RCS1187 in the following example will lead to a compile-time error (CS0110):

    private static readonly LogLevel LogLevel = LogLevel.Information;

josefpihrt
josefpihrt requested changes Aug 10, 2023
View reviewed changes
ChangeLog.md Outdated Show resolved Hide resolved
@josefpihrt josefpihrt merged commit 25288a7 into dotnet:main Aug 12, 2023
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
@jamesHargreaves12 @josefpihrt @JochemHarmes
Fix RCS1187 (dotnet#1150)
96f8587 
Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefpihrt josefpihrt josefpihrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesHargreaves12 @josefpihrt