Implement analysis and fix for OrderBy(x => x) to Order()

[BenjaminBrienen]

Fixes #1492

TODO:

• Unit test fails because the unit test is run with a version of .NET Core where System.Linq does not yet implement IEnumerable<T>.Order().

[BenjaminBrienen]

@josefpihrt I added a conditional compilation on the unit test and a feature detection on the analyzer. If you want to handle this a different way, just let me know! :)

[josefpihrt]

Please update changelog.

[BenjaminBrienen]

At the moment, I only see methods for adding arguments and ArgumentsList doesn't have a public constructor.

[josefpihrt]

You can use combination of With... methods and SyntaxFactory methods:

newInvocationExpression = newInvocationExpression.WithArgumentList(
    newInvocationExpression.ArgumentList.WithArguments(
        SyntaxFactory.SeparatedList<ArgumentSyntax>()));

[BenjaminBrienen]

You can use combination of With... methods and SyntaxFactory methods:

newInvocationExpression = newInvocationExpression.WithArgumentList(
    newInvocationExpression.ArgumentList.WithArguments(
        SyntaxFactory.SeparatedList<ArgumentSyntax>()));

Ah, I just found another way using RemoveNodes, but this works too! (and it is better)

[BenjaminBrienen]

I've doubled checked that all tests pass, so it should be ready for final review.

[josefpihrt]

Build is failing.

[BenjaminBrienen]

Build is failing.

Oh wow, it fails even with a little info message. Good to know there are tight checks! Fixed.

[josefpihrt]

Great PR! Thanks for the contribution! 👍