re-enable tests for 66421 (#73052)

dotnet · Jul 29, 2022 · 20b42d5 · 20b42d5
1 parent c734a8e
commit 20b42d5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 33 deletions.
diff --git a/...System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.IgnoreCycles.cs b/...System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.IgnoreCycles.cs
@@ -134,9 +134,6 @@ public async Task IgnoreCycles_OnDictionary(Type typeToSerialize)
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task IgnoreCycles_OnRecursiveDictionary()
         {
             var root = new RecursiveDictionary();
@@ -183,9 +180,6 @@ public async Task IgnoreCycles_OnList(Type typeToSerialize)
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task IgnoreCycles_OnRecursiveList()
         {
             var root = new RecursiveList();
@@ -240,9 +234,6 @@ public async Task IgnoreCycles_OnExtensionData()
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task IgnoreCycles_DoesNotSupportPreserveSemantics()
         {
             // Object
@@ -279,9 +270,6 @@ public async Task IgnoreCycles_DoesNotSupportPreserveSemantics()
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task IgnoreCycles_DoesNotSupportPreserveSemantics_Polymorphic()
         {
             // Object

diff --git a/src/libraries/System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.cs b/src/libraries/System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.cs
@@ -242,9 +242,6 @@ public async Task UnicodePropertyNames()
         public class DictionaryWithGenericCycle : Dictionary<string, DictionaryWithGenericCycle> { }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task DictionaryLoop()
         {
             DictionaryWithGenericCycle root = new DictionaryWithGenericCycle();
@@ -261,9 +258,6 @@ public async Task DictionaryLoop()
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task DictionaryPreserveDuplicateDictionaries()
         {
             DictionaryWithGenericCycle root = new DictionaryWithGenericCycle();
@@ -298,9 +292,6 @@ public async Task DictionaryObjectLoop()
         public class DictionaryWithGenericCycleWithinList : Dictionary<string, List<DictionaryWithGenericCycleWithinList>> { }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task DictionaryArrayLoop()
         {
             DictionaryWithGenericCycleWithinList root = new DictionaryWithGenericCycleWithinList();
@@ -316,9 +307,6 @@ public async Task DictionaryArrayLoop()
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task DictionaryPreserveDuplicateArrays()
         {
             DictionaryWithGenericCycleWithinList root = new DictionaryWithGenericCycleWithinList();
@@ -449,9 +437,6 @@ public async Task UnicodeDictionaryKeys()
         public class ListWithGenericCycle : List<ListWithGenericCycle> { }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task ArrayLoop()
         {
             ListWithGenericCycle root = new ListWithGenericCycle();
@@ -518,9 +503,6 @@ public async Task ArrayPreserveDuplicateObjects()
         public class ListWithGenericCycleWithinDictionary : List<Dictionary<string, ListWithGenericCycleWithinDictionary>> { }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task ArrayDictionaryLoop()
         {
             ListWithGenericCycleWithinDictionary root = new ListWithGenericCycleWithinDictionary();
@@ -536,9 +518,6 @@ public async Task ArrayDictionaryLoop()
         }
 
         [Fact]
-#if BUILDING_SOURCE_GENERATOR_TESTS
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
-#endif
         public async Task ArrayPreserveDuplicateDictionaries()
         {
             ListWithGenericCycleWithinDictionary root = new ListWithGenericCycleWithinDictionary