Remove the extra diagnostic we emit when the compiler failed to parse…

… the attribute. The C# compiler will already fail so just let it emit its diagnostics. Fixes #69827
dotnet · May 25, 2022 · 2b382d3 · 2b382d3
1 parent 032a7dc
commit 2b382d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...aries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs b/...aries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs
@@ -274,7 +274,6 @@ private static IncrementalStubGenerationContext CalculateStubInformation(
 
             if (libraryImportData is null)
             {
-                generatorDiagnostics.ReportConfigurationNotSupported(generatedDllImportAttr!, "Invalid syntax");
                 libraryImportData = new LibraryImportData("INVALID_CSHARP_SYNTAX");
             }
 

diff --git a/...ies/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CompileFails.cs b/...ies/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CompileFails.cs
@@ -149,9 +149,9 @@ public static IEnumerable<object[]> CodeSnippetsToCompile_InvalidCode()
         {
             yield return new object[] { CodeSnippets.RecursiveImplicitlyBlittableStruct, 0, 1 };
             yield return new object[] { CodeSnippets.MutuallyRecursiveImplicitlyBlittableStruct, 0, 2 };
-            yield return new object[] { CodeSnippets.PartialPropertyName, 1, 2 };
-            yield return new object[] { CodeSnippets.InvalidConstantForModuleName, 1, 1 };
-            yield return new object[] { CodeSnippets.IncorrectAttributeFieldType, 1, 1 };
+            yield return new object[] { CodeSnippets.PartialPropertyName, 0, 2 };
+            yield return new object[] { CodeSnippets.InvalidConstantForModuleName, 0, 1 };
+            yield return new object[] { CodeSnippets.IncorrectAttributeFieldType, 0, 1 };
         }
 
         [Theory]
-Original file line number
+Diff line change
@@ Expand Up @@
                 if (libraryImportData is null)
                 {
-                    generatorDiagnostics.ReportConfigurationNotSupported(generatedDllImportAttr!, "Invalid syntax");
                     libraryImportData = new LibraryImportData("INVALID_CSHARP_SYNTAX");
                 }
@@ Expand Down @@