Remove excess allocations in Uri.ReCreateParts (#34864)

* Remove excess allocations in Uri.ReCreateParts * Fix Compression offset * Revert VSB optimizations * Use noEscape.Length * Simplify TryGetUnicodeEquivalent * Remove ValueStringBuilderExtensions * Index into chars instead of dest * Remove unreachable code block * Use StackallocThreshold constant * Add comments about why MemoryMarshal is used to recreate the span
dotnet · Jan 22, 2021 · 39d72d4 · 39d72d4
1 parent f1ad1b9
commit 39d72d4
Show file tree

Hide file tree

Showing 5 changed files with 236 additions and 296 deletions.
diff --git a/src/libraries/System.Private.Uri/src/System/IriHelper.cs b/src/libraries/System.Private.Uri/src/System/IriHelper.cs
@@ -89,8 +89,8 @@ internal static bool CheckIsReserved(char ch, UriComponents component)
         internal static unsafe string EscapeUnescapeIri(char* pInput, int start, int end, UriComponents component)
         {
             int size = end - start;
-            ValueStringBuilder dest = size <= 256
-                ? new ValueStringBuilder(stackalloc char[256])
+            var dest = size <= Uri.StackallocThreshold
+                ? new ValueStringBuilder(stackalloc char[Uri.StackallocThreshold])
                 : new ValueStringBuilder(size);
 
             Span<byte> maxUtf8EncodedSpan = stackalloc byte[4];