Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@pavelsavara
pavelsavara committed Jun 21, 2021
1 parent 74dfcb4 commit 42ad7fb
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ public sealed class SocketWrapper : IDisposable

public SocketWrapper(Socket socket)
{
this._socket = socket; _websocket = null;
_socket = socket;
}
public SocketWrapper(WebSocket websocket)
{
this._socket = null; _websocket = websocket;
_websocket = websocket;
}

public void Dispose()
Expand Down
22 changes: 11 additions & 11 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public async Task GetAsync_IPBasedUri_Success(IPAddress address)
}

using HttpClientHandler handler = CreateHttpClientHandler();
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
handler.ServerCertificateCustomValidationCallback = TestHelper.AllowAllCertificates;
}
Expand Down Expand Up @@ -277,7 +277,7 @@ public async Task GetAsync_SecureAndNonSecureIPBasedUri_CorrectlyFormatted(IPAdd
return;
}

var options = new LoopbackServer.Options { Address = address, UseSsl= useSsl };
var options = new LoopbackServer.Options { Address = address, UseSsl = useSsl };
bool connectionAccepted = false;
string host = "";

Expand Down Expand Up @@ -410,7 +410,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
var request = new HttpRequestMessage(HttpMethod.Post, uri) { Content = new ByteArrayContent(contentArray), Version = UseVersion };
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("text/plain"));
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
request.Headers.AcceptCharset.Add(new StringWithQualityHeaderValue("utf-8"));
request.Headers.AcceptEncoding.Add(new StringWithQualityHeaderValue("gzip"));
Expand All @@ -426,7 +426,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
request.Headers.Connection.Add("close");
request.Headers.Add("Cookie", "$Version=1; Skin=new");
request.Content.Headers.ContentLength = contentArray.Length;
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
request.Content.Headers.ContentMD5 = MD5.Create().ComputeHash(contentArray);
}
Expand All @@ -451,7 +451,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
request.Headers.TE.Add(new TransferCodingWithQualityHeaderValue("deflate"));
request.Headers.Trailer.Add("MyTrailer");
request.Headers.TransferEncoding.Add(new TransferCodingHeaderValue("chunked"));
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
request.Headers.UserAgent.Add(new ProductInfoHeaderValue(new ProductHeaderValue("Mozilla", "5.0")));
request.Headers.Upgrade.Add(new ProductHeaderValue("HTTPS", "1.3"));
Expand Down Expand Up @@ -494,7 +494,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Assert.Equal(content, Encoding.ASCII.GetString(requestData.Body));
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
Assert.Equal("utf-8", requestData.GetSingleHeaderValue("Accept-Charset"));
Assert.Equal("gzip, deflate", requestData.GetSingleHeaderValue("Accept-Encoding"));
Expand All @@ -506,7 +506,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Assert.Equal("12", requestData.GetSingleHeaderValue("Age"));
Assert.Equal("Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==", requestData.GetSingleHeaderValue("Authorization"));
Assert.Equal("no-cache", requestData.GetSingleHeaderValue("Cache-Control"));
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
Assert.Equal("$Version=1; Skin=new", requestData.GetSingleHeaderValue("Cookie"));
Assert.Equal("Tue, 15 Nov 1994 08:12:31 GMT", requestData.GetSingleHeaderValue("Date"));
Expand Down Expand Up @@ -556,7 +556,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Assert.Equal(0, requestData.GetHeaderValueCount("Connection"));
Assert.Equal(0, requestData.GetHeaderValueCount("Transfer-Encoding"));
}
else if(PlatformDetection.IsNotBrowser)
else if (PlatformDetection.IsNotBrowser)
{
// Verify HTTP/1.x headers
Assert.Equal("close", requestData.GetSingleHeaderValue("Connection"), StringComparer.OrdinalIgnoreCase); // NetFxHandler uses "Close" vs "close"
Expand Down Expand Up @@ -594,7 +594,7 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
{
Assert.Equal("1.1", resp.Version.ToString());
Assert.Equal(HttpStatusCode.OK, resp.StatusCode);
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
Assert.Contains("*", resp.Headers.GetValues("Access-Control-Allow-Origin"));
}
Expand All @@ -613,7 +613,7 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
Assert.Contains("gzip", resp.Content.Headers.ContentEncoding);
Assert.Contains("da", resp.Content.Headers.ContentLanguage);
Assert.Equal(new Uri("/index.htm", UriKind.Relative), resp.Content.Headers.ContentLocation);
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
Assert.Equal(Convert.FromBase64String("Q2hlY2sgSW50ZWdyaXR5IQ=="), resp.Content.Headers.ContentMD5);
}
Expand All @@ -636,7 +636,7 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
Assert.Equal(TimeSpan.FromSeconds(120), resp.Headers.RetryAfter.Delta.GetValueOrDefault());
Assert.Contains(new ProductInfoHeaderValue("Apache", "2.4.1"), resp.Headers.Server);
if(PlatformDetection.IsNotBrowser)
if (PlatformDetection.IsNotBrowser)
{
Assert.Contains("UserID=JohnDoe; Max-Age=3600; Version=1", resp.Headers.GetValues("Set-Cookie"));
}
Expand Down

0 comments on commit 42ad7fb

Please sign in to comment.