Skip CPU time on mobile

dotnet · Jul 24, 2024 · 4f89894 · 4f89894
1 parent bebcfaa
commit 4f89894
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/...ries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs b/...ries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs
@@ -148,13 +148,13 @@ static RuntimeMetrics()
             description: "The number of processors available to the process.");
 
         private static readonly ObservableCounter<double>? s_processCpuTime =
-                                    OperatingSystem.IsBrowser() || OperatingSystem.IsTvOS() || (OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst()) ?
-                                    null :
-                                    s_meter.CreateObservableCounter(
-                                        "dotnet.process.cpu.time",
-                                        GetCpuTime,
-                                        unit: "s",
-                                        description: "CPU time used by the process.");
+            OperatingSystem.IsBrowser() || OperatingSystem.IsTvOS() || (OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst()) ?
+            null :
+            s_meter.CreateObservableCounter(
+                "dotnet.process.cpu.time",
+                GetCpuTime,
+                unit: "s",
+                description: "CPU time used by the process.");
 
         public static bool IsEnabled()
         {

diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/tests/RuntimeMetricsTests.cs b/src/libraries/System.Diagnostics.DiagnosticSource/tests/RuntimeMetricsTests.cs
@@ -116,7 +116,7 @@ public void GcCollectionsCount()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMobile))]
         public void CpuTime()
         {
            using InstrumentRecorder<double> instrumentRecorder = new("dotnet.process.cpu.time");
@@ -125,7 +125,7 @@ public void CpuTime()
 
            bool[] foundCpuModes = [false, false];
 
-           foreach (Measurement<double> measurement in instrumentRecorder.GetMeasurements().Where(m => m.Value >= 0))
+           foreach (Measurement<double> measurement in instrumentRecorder.GetMeasurements())
            {
                var tags = measurement.Tags.ToArray();
                var tag = tags.SingleOrDefault(k => k.Key == "cpu.mode");