update test case and fix some formatting

dotnet · Jul 31, 2024 · 5ec8c18 · 5ec8c18
1 parent f906cbb
commit 5ec8c18
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
@@ -2168,7 +2168,12 @@ public async Task IgnoreConditionWhenWritingDefault_WinsOver_IgnoreReadOnlyField
         [Fact]
         public async Task JsonIgnoreCondition_WhenWriting()
         {
-            var json = await Serializer.SerializeWrapper(new JsonIgnoreCondition_WhenReadingWritingTestModel{ Age = 10, Name = "Mike" });
+            var options = new JsonSerializerOptions { IgnoreReadOnlyProperties = true };
+            var json = await Serializer.SerializeWrapper
+                (
+                    new JsonIgnoreCondition_WhenReadingWritingTestModel { Age = 10, Name = "Mike" },
+                    options
+                );
             Assert.Equal("""{"Age":10}""", json);
         }
 
@@ -2182,7 +2187,7 @@ public async Task JsonIgnoreCondition_WhenReading()
         }
 
         public class JsonIgnoreCondition_WhenReadingWritingTestModel
-        {  
+        {
             [JsonIgnore(Condition = JsonIgnoreCondition.WhenReading)]
             public int Age { get; set; }
             [JsonIgnore(Condition = JsonIgnoreCondition.WhenWriting)]

diff --git a/...on/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs b/...on/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs
@@ -129,7 +129,7 @@ public override async Task HonorJsonPropertyName_PrivateGetter()
             Assert.Equal(MySmallEnum.AnotherValue, obj.GetProxy());
 
             // JsonInclude for private members not supported in source gen
-            await Assert.ThrowsAsync<InvalidOperationException>(async() => await Serializer.SerializeWrapper(obj));
+            await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.SerializeWrapper(obj));
         }
 
         [Fact]
@@ -331,7 +331,8 @@ public override async Task ClassWithIgnoredAndPrivateMembers_DoesNotIncludeIgnor
         [JsonSerializable(typeof(IDiamondInterfaceHierarchyWithNamingConflict.IJoinInterface), TypeInfoPropertyName = "IDiamondInterfaceHierarchyWithNamingConflictIJoinInterface")]
         [JsonSerializable(typeof(IDiamondInterfaceHierarchyWithNamingConflictUsingAttribute.IJoinInterface), TypeInfoPropertyName = "IDiamondInterfaceHierarchyWithNamingConflictUsingAttributeIJoinInterface")]
         [JsonSerializable(typeof(CollectionWithPrivateElementType))]
-        [JsonSerializable(typeof(DictionaryWithPrivateKeyAndValueType))][JsonSerializable(typeof(ClassWithIgnoredAndPrivateMembers))]
+        [JsonSerializable(typeof(DictionaryWithPrivateKeyAndValueType))]
+        [JsonSerializable(typeof(ClassWithIgnoredAndPrivateMembers))]
         [JsonSerializable(typeof(ClassWithInternalJsonIncludeProperties))]
         [JsonSerializable(typeof(ClassWithIgnoredAndPrivateMembers))]
         [JsonSerializable(typeof(ClassUsingIgnoreWhenWritingDefaultAttribute))]