Skip to content

Commit

Permalink
Applying formatting patch
Browse files Browse the repository at this point in the history
  • Loading branch information
tannergooding committed May 18, 2020
1 parent 47498ce commit 67cbbb8
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 22 deletions.
3 changes: 1 addition & 2 deletions src/coreclr/src/jit/codegenarm64.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4323,8 +4323,7 @@ void CodeGen::genSIMDIntrinsicBinOp(GenTreeSIMD* simdNode)
assert(simdNode->gtSIMDIntrinsicID == SIMDIntrinsicAdd || simdNode->gtSIMDIntrinsicID == SIMDIntrinsicSub ||
simdNode->gtSIMDIntrinsicID == SIMDIntrinsicMul || simdNode->gtSIMDIntrinsicID == SIMDIntrinsicDiv ||
simdNode->gtSIMDIntrinsicID == SIMDIntrinsicBitwiseAnd ||
simdNode->gtSIMDIntrinsicID == SIMDIntrinsicBitwiseOr ||
simdNode->gtSIMDIntrinsicID == SIMDIntrinsicEqual);
simdNode->gtSIMDIntrinsicID == SIMDIntrinsicBitwiseOr || simdNode->gtSIMDIntrinsicID == SIMDIntrinsicEqual);

GenTree* op1 = simdNode->gtGetOp1();
GenTree* op2 = simdNode->gtGetOp2();
Expand Down
6 changes: 4 additions & 2 deletions src/coreclr/src/jit/compiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -2621,8 +2621,10 @@ class Compiler
var_types baseType,
unsigned size);

GenTreeHWIntrinsic* gtNewSimdAsHWIntrinsicNode(
var_types type, NamedIntrinsic hwIntrinsicID, var_types baseType, unsigned size)
GenTreeHWIntrinsic* gtNewSimdAsHWIntrinsicNode(var_types type,
NamedIntrinsic hwIntrinsicID,
var_types baseType,
unsigned size)
{
GenTreeHWIntrinsic* node = gtNewSimdHWIntrinsicNode(type, hwIntrinsicID, baseType, size);
node->gtFlags |= GTF_SIMDASHW_OP;
Expand Down
9 changes: 4 additions & 5 deletions src/coreclr/src/jit/lowerarmarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,8 @@ void Lowering::LowerHWIntrinsicCmpOp(GenTreeHWIntrinsic* node, genTreeOps cmpOp)
unsigned simdSize = node->gtSIMDSize;
var_types simdType = Compiler::getSIMDTypeForSize(simdSize);

assert((intrinsicId == NI_Vector64_op_Equality) ||
(intrinsicId == NI_Vector64_op_Inequality) ||
(intrinsicId == NI_Vector128_op_Equality) ||
(intrinsicId == NI_Vector128_op_Inequality));
assert((intrinsicId == NI_Vector64_op_Equality) || (intrinsicId == NI_Vector64_op_Inequality) ||
(intrinsicId == NI_Vector128_op_Equality) || (intrinsicId == NI_Vector128_op_Inequality));

assert(varTypeIsSIMD(simdType));
assert(varTypeIsArithmetic(baseType));
Expand Down Expand Up @@ -651,7 +649,8 @@ void Lowering::LowerHWIntrinsicCmpOp(GenTreeHWIntrinsic* node, genTreeOps cmpOp)
GenTree* insCns = comp->gtNewIconNode(cmpOp == GT_EQ ? -1 : 0, TYP_INT);
BlockRange().InsertAfter(idxCns, insCns);

GenTree* tmp = comp->gtNewSimdAsHWIntrinsicNode(simdType, cmp, idxCns, insCns, NI_AdvSimd_Insert, TYP_INT, simdSize);
GenTree* tmp =
comp->gtNewSimdAsHWIntrinsicNode(simdType, cmp, idxCns, insCns, NI_AdvSimd_Insert, TYP_INT, simdSize);
BlockRange().InsertAfter(insCns, tmp);
LowerNode(tmp);

Expand Down
6 changes: 2 additions & 4 deletions src/coreclr/src/jit/lowerxarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1120,10 +1120,8 @@ void Lowering::LowerHWIntrinsicCmpOp(GenTreeHWIntrinsic* node, genTreeOps cmpOp)
unsigned simdSize = node->gtSIMDSize;
var_types simdType = Compiler::getSIMDTypeForSize(simdSize);

assert((intrinsicId == NI_Vector128_op_Equality) ||
(intrinsicId == NI_Vector128_op_Inequality) ||
(intrinsicId == NI_Vector256_op_Equality) ||
(intrinsicId == NI_Vector256_op_Inequality));
assert((intrinsicId == NI_Vector128_op_Equality) || (intrinsicId == NI_Vector128_op_Inequality) ||
(intrinsicId == NI_Vector256_op_Equality) || (intrinsicId == NI_Vector256_op_Inequality));

assert(varTypeIsSIMD(simdType));
assert(varTypeIsArithmetic(baseType));
Expand Down
3 changes: 1 addition & 2 deletions src/coreclr/src/jit/lsrabuild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1507,8 +1507,7 @@ int LinearScan::ComputeOperandDstCount(GenTree* operand)
// Stores and void-typed operands may be encountered when processing call nodes, which contain
// pointers to argument setup stores.
assert(operand->OperIsStore() || operand->OperIsBlkOp() || operand->OperIsPutArgStk() ||
operand->OperIsCompare() || operand->OperIs(GT_CMP) ||
operand->TypeGet() == TYP_VOID);
operand->OperIsCompare() || operand->OperIs(GT_CMP) || operand->TypeGet() == TYP_VOID);
return 0;
}
}
Expand Down
6 changes: 4 additions & 2 deletions src/coreclr/src/jit/namedintrinsiclist.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@ enum NamedIntrinsic : unsigned short

NI_SIMD_AS_HWINTRINSIC_START,
#if defined(TARGET_XARCH)
#define SIMD_AS_HWINTRINSIC(classId, id, name, numarg, t1, t2, t3, t4, t5, t6, t7, t8, t9, t10, flag) NI_##classId##_##id,
#define SIMD_AS_HWINTRINSIC(classId, id, name, numarg, t1, t2, t3, t4, t5, t6, t7, t8, t9, t10, flag) \
NI_##classId##_##id,
#include "simdashwintrinsiclistxarch.h"
#elif defined(TARGET_ARM64)
#define SIMD_AS_HWINTRINSIC(classId, id, name, numarg, t1, t2, t3, t4, t5, t6, t7, t8, t9, t10, flag) NI_##classId##_##id,
#define SIMD_AS_HWINTRINSIC(classId, id, name, numarg, t1, t2, t3, t4, t5, t6, t7, t8, t9, t10, flag) \
NI_##classId##_##id,
#include "simdashwintrinsiclistarm64.h"
#endif // !defined(TARGET_XARCH) && !defined(TARGET_ARM64)
NI_SIMD_AS_HWINTRINSIC_END,
Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/src/jit/simdashwintrinsic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ GenTree* Compiler::impSimdAsHWIntrinsic(NamedIntrinsic intrinsic,
{
argType = isInstanceMethod ? simdType
: JITtype2varType(strip(info.compCompHnd->getArgType(sig, argList, &argClass)));
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);

assert(!SimdAsHWIntrinsicInfo::NeedsOperandsSwapped(intrinsic));
return gtNewSimdAsHWIntrinsicNode(retType, op1, hwIntrinsic, baseType, simdSize);
Expand All @@ -305,7 +305,7 @@ GenTree* Compiler::impSimdAsHWIntrinsic(NamedIntrinsic intrinsic,

argType = isInstanceMethod ? simdType
: JITtype2varType(strip(info.compCompHnd->getArgType(sig, argList, &argClass)));
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);

if (SimdAsHWIntrinsicInfo::NeedsOperandsSwapped(intrinsic))
{
Expand Down Expand Up @@ -415,7 +415,7 @@ GenTree* Compiler::impSimdAsHWIntrinsicSpecial(NamedIntrinsic intrinsic,

argType = isInstanceMethod ? simdType
: JITtype2varType(strip(info.compCompHnd->getArgType(sig, argList, &argClass)));
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);

assert(!SimdAsHWIntrinsicInfo::NeedsOperandsSwapped(intrinsic));

Expand Down Expand Up @@ -521,7 +521,7 @@ GenTree* Compiler::impSimdAsHWIntrinsicSpecial(NamedIntrinsic intrinsic,

argType = isInstanceMethod ? simdType
: JITtype2varType(strip(info.compCompHnd->getArgType(sig, argList, &argClass)));
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);

assert(!SimdAsHWIntrinsicInfo::NeedsOperandsSwapped(intrinsic));

Expand Down Expand Up @@ -775,7 +775,7 @@ GenTree* Compiler::impSimdAsHWIntrinsicSpecial(NamedIntrinsic intrinsic,

argType = isInstanceMethod ? simdType
: JITtype2varType(strip(info.compCompHnd->getArgType(sig, argList, &argClass)));
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);
op1 = getArgForHWIntrinsic(argType, argClass, isInstanceMethod);

assert(!SimdAsHWIntrinsicInfo::NeedsOperandsSwapped(intrinsic));

Expand Down

0 comments on commit 67cbbb8

Please sign in to comment.