Big-endian test case fixes: BinaryWriter (#49688)

* Fix endian assumption in BinaryWriter_WriteSpan (BinaryWriter always uses little-endian byte order)
dotnet · Mar 16, 2021 · 6866357 · 6866357
1 parent 3982863
commit 6866357
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/libraries/System.IO/tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs b/src/libraries/System.IO/tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs
@@ -579,13 +579,13 @@ public void BinaryWriter_WriteSpan()
 
                     char testChar;
 
-                    testChar = BitConverter.ToChar(new byte[] { (byte)baseStream.ReadByte(), (byte)baseStream.ReadByte() }, 0);
+                    testChar = (char)((ushort)baseStream.ReadByte() + ((ushort)baseStream.ReadByte() << 8));
                     Assert.Equal('a', testChar);
 
-                    testChar = BitConverter.ToChar(new byte[] { (byte)baseStream.ReadByte(), (byte)baseStream.ReadByte() }, 0);
+                    testChar = (char)((ushort)baseStream.ReadByte() + ((ushort)baseStream.ReadByte() << 8));
                     Assert.Equal('7', testChar);
 
-                    testChar = BitConverter.ToChar(new byte[] { (byte)baseStream.ReadByte(), (byte)baseStream.ReadByte() }, 0);
+                    testChar = (char)((ushort)baseStream.ReadByte() + ((ushort)baseStream.ReadByte() << 8));
                     Assert.Equal(char.MaxValue, testChar);
                 }
             }