Address feedback on DiagnosticId changes (#105096)

See feedback in #105049
dotnet · Jul 19, 2024 · 6aa2862 · 6aa2862
1 parent 6068519
commit 6aa2862
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/tools/illink/src/ILLink.Shared/DiagnosticId.cs b/src/tools/illink/src/ILLink.Shared/DiagnosticId.cs
@@ -187,7 +187,7 @@ public enum DiagnosticId
 		_unused_DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMemberOnBase = 2120,
 		RedundantSuppression = 2121,
 		TypeNameIsNotAssemblyQualified = 2122,
-		_EndTrimAnalysisWarningsSentinel = 2123,
+		_EndTrimAnalysisWarningsSentinel,
 
 		// Single-file diagnostic ids.
 		AvoidAssemblyLocationInSingleFile = 3000,
@@ -204,7 +204,7 @@ public enum DiagnosticId
 		GenericRecursionCycle = 3054,
 		CorrectnessOfAbstractDelegatesCannotBeGuaranteed = 3055,
 		RequiresDynamicCodeOnStaticConstructor = 3056,
-		_EndAotAnalysisWarningsSentinel = 3057,
+		_EndAotAnalysisWarningsSentinel,
 
 		// Feature guard diagnostic ids.
 		ReturnValueDoesNotMatchFeatureGuards = 4000,
@@ -229,9 +229,9 @@ public static string GetDiagnosticSubcategory (this DiagnosticId diagnosticId) =
 				2103 => MessageSubCategory.TrimAnalysis,
 				2106 => MessageSubCategory.TrimAnalysis,
 				2107 => MessageSubCategory.TrimAnalysis,
-				>= 2109 and <= (int) DiagnosticId._EndTrimAnalysisWarningsSentinel => MessageSubCategory.TrimAnalysis,
+				>= 2109 and < (int) DiagnosticId._EndTrimAnalysisWarningsSentinel => MessageSubCategory.TrimAnalysis,
 				>= 3050 and <= 3052 => MessageSubCategory.AotAnalysis,
-				>= 3054 and <= (int) DiagnosticId._EndAotAnalysisWarningsSentinel => MessageSubCategory.AotAnalysis,
+				>= 3054 and < (int) DiagnosticId._EndAotAnalysisWarningsSentinel => MessageSubCategory.AotAnalysis,
 				_ => MessageSubCategory.None,
 			};