Disable Long Running JSON tests on Checked CoreCLR (#45505)

* Disable Long Running JSON tests on Checked CoreCLR * PR Feedback
dotnet · Dec 3, 2020 · 87c3cb7 · 87c3cb7
1 parent 0079d87
commit 87c3cb7
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 0 deletions.
diff --git a/src/libraries/System.Text.Json/tests/JsonDocumentTests.cs b/src/libraries/System.Text.Json/tests/JsonDocumentTests.cs
@@ -472,6 +472,7 @@ public static void ParseJson_UnseekableStream_BadBOM(string json)
 
         [Theory]
         [MemberData(nameof(BadBOMCases))]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public static Task ParseJson_UnseekableStream_Async_BadBOM(string json)
         {
             byte[] data = Encoding.UTF8.GetBytes(json);

diff --git a/...libraries/System.Text.Json/tests/Serialization/ConstructorTests/ConstructorTests.Cache.cs b/...libraries/System.Text.Json/tests/Serialization/ConstructorTests/ConstructorTests.Cache.cs
@@ -125,6 +125,7 @@ public async Task PropertyCacheWithMinInputsLast()
         private JsonSerializerOptions s_options = new JsonSerializerOptions();
 
         [Fact]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public async Task MultipleTypes()
         {
             void Serialize<T>(object[] args)

diff --git a/...ibraries/System.Text.Json/tests/Serialization/ConstructorTests/ConstructorTests.Stream.cs b/...ibraries/System.Text.Json/tests/Serialization/ConstructorTests/ConstructorTests.Stream.cs
@@ -11,6 +11,7 @@ namespace System.Text.Json.Serialization.Tests
     public abstract partial class ConstructorTests
     {
         [Fact]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public async Task ReadSimpleObjectAsync()
         {
             async Task RunTestAsync<T>(byte[] testData)

diff --git a/src/libraries/System.Text.Json/tests/Serialization/ContinuationTests.cs b/src/libraries/System.Text.Json/tests/Serialization/ContinuationTests.cs
@@ -181,6 +181,7 @@ public static async Task InvalidJsonShouldFailAtAnyPosition_Stream(
         [Theory]
         [MemberData(nameof(TestData), /* enumeratePayloadTweaks: */ false)]
         [ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public static void ShouldWorkAtAnyPosition_Sequence(
             string json,
             int bufferSize,

diff --git a/src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs b/src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs
@@ -601,6 +601,7 @@ private static void AssertDictionaryElements_StringValues(string serialized)
 
         [Fact]
         [ActiveIssue("https://github.com/dotnet/runtime/issues/39674", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter))]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public static void DictionariesRoundTrip()
         {
             RunAllDictionariessRoundTripTest(JsonNumberTestData.ULongs);

diff --git a/src/libraries/System.Text.Json/tests/Serialization/Stream.WriteTests.cs b/src/libraries/System.Text.Json/tests/Serialization/Stream.WriteTests.cs
@@ -49,6 +49,7 @@ public static async Task NullObjectValue()
         }
 
         [Fact]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public static async Task RoundTripAsync()
         {
             byte[] buffer;

diff --git a/src/libraries/System.Text.Json/tests/Utf8JsonReaderTests.MultiSegment.cs b/src/libraries/System.Text.Json/tests/Utf8JsonReaderTests.MultiSegment.cs
@@ -1839,6 +1839,7 @@ private static void TrailingCommasHelper(ReadOnlySequence<byte> utf8, JsonReader
         [InlineData("{\"Property1\": {\"Property1.1\": 42} // comment\n,5}")]
         [InlineData("{\"Property1\": {\"Property1.1\": 42}, // comment\n // comment\n5}")]
         [InlineData("{// comment\n5}")]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public static void ReadInvalidJsonStringsWithComments(string jsonString)
         {
             byte[] input = Encoding.UTF8.GetBytes(jsonString);

diff --git a/src/libraries/System.Text.Json/tests/Utf8JsonWriterTests.cs b/src/libraries/System.Text.Json/tests/Utf8JsonWriterTests.cs
@@ -3120,6 +3120,7 @@ public void WritingLargestPossibleBase64Bytes(bool formatted, bool skipValidatio
         [InlineData(true, false)]
         [InlineData(false, true)]
         [InlineData(false, false)]
+        [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
         public void Writing3MBBase64Bytes(bool formatted, bool skipValidation)
         {
             byte[] value = new byte[3 * 1024 * 1024];
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,7 @@ public static async Task NullObjectValue() @@
             }
             [Fact]
+            [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", RuntimeConfiguration.Checked)]
             public static async Task RoundTripAsync()
             {
                 byte[] buffer;
@@ Expand Down @@