Skip to content

Commit

Permalink
Throw IOException for all other reparse points.
Browse files Browse the repository at this point in the history
  • Loading branch information
@carlossanlop
carlossanlop committed Jul 18, 2023
1 parent 53e2ad8 commit 9d17d9c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Windows.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ private TarEntry ConstructEntryForWriting(string fullPath, string entryName, Fil
}
else
{
// Treat any other reparse point as regular file
entryType = TarHelpers.GetRegularFileEntryTypeForFormat(Format);
// All other reparse points are not supported since they cannot be
// represented in a tar file using the existing entry types.
throw new IOException(SR.Format(SR.TarUnsupportedFile, fullPath));

This comment has been minimized.

Sign in to view

Copy link
@billfreist

billfreist Jul 19, 2023

This is going to cause the same issue to happen with the duplication reparse point that caused my initial issue. Theres a handful of valid reparse points that should simply treat the file as a normal file, such as dedup and OneDrive, for example.

This comment has been minimized.

Sign in to view

Copy link
@billfreist

billfreist Jul 19, 2023

Specifically IO_REPARSE_TAG_DEDUP in my case, but the cloud file provider tags IO_REPARSE_TAG_CLOUD and friends would likely result in the same issue if someone tried to tar a file/folder thats synchronized from OneDrive, for example.
}
}
else if (isDirectory)
Expand Down

0 comments on commit 9d17d9c

Please sign in to comment.