Skip to content

Commit

Permalink
Stop complaining about console output mismatch
Browse files Browse the repository at this point in the history
  • Loading branch information
@cshung
cshung committed Mar 26, 2024
1 parent fffeee0 commit b0e6945
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 21 deletions.
3 changes: 2 additions & 1 deletion src/libraries/System.Console/tests/NonStandardConfiguration.Unix.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ namespace System.Tests
public partial class NonStandardConfigurationTests
{
[PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invokes
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// I am modifying stdout to log what I needed
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void NonBlockingStdout_AllDataReceived()
{
RemoteInvokeHandle remote = RemoteExecutor.Invoke(() =>
Expand Down
38 changes: 19 additions & 19 deletions src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace System.Diagnostics.Tests
{
public class ProcessStreamReadTests : ProcessTestBase
{
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestSyncErrorStream()
{
Process p = CreateProcessPortable(RemotelyInvokable.ErrorProcessBody);
Expand All @@ -28,7 +28,7 @@ public void TestSyncErrorStream()
Assert.True(p.WaitForExit(WaitInMS));
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestAsyncErrorStream()
{
for (int i = 0; i < 2; ++i)
Expand All @@ -55,7 +55,7 @@ public void TestAsyncErrorStream()
}
}

[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[InlineData(false)]
[InlineData(true)]
public void TestAsyncErrorStream_SynchronizingObject(bool invokeRequired)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Threading)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 61 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L61 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(61,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)
Expand Down Expand Up @@ -86,7 +86,7 @@ public void TestAsyncErrorStream_SynchronizingObject(bool invokeRequired)
Assert.Equal(invokeRequired ? 3 : 0, invokeCalled);
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestSyncOutputStream()
{
Process p = CreateProcessPortable(RemotelyInvokable.StreamBody);
Expand All @@ -97,7 +97,7 @@ public void TestSyncOutputStream()
Assert.Equal(RemotelyInvokable.TestConsoleApp + " started" + Environment.NewLine + RemotelyInvokable.TestConsoleApp + " closed" + Environment.NewLine, s);
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestAsyncOutputStream()
{
for (int i = 0; i < 2; ++i)
Expand All @@ -123,7 +123,7 @@ public void TestAsyncOutputStream()
}
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
async public Task TestAsyncOutputStream_CancelOutputRead()
{
// This test might have some false negatives due to possible race condition in System.Diagnostics.AsyncStreamReader.ReadBufferAsync
Expand Down Expand Up @@ -206,7 +206,7 @@ async private Task<int> TestAsyncOutputStream_CancelOutputRead_RemotelyInvokable
}
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
async public Task TestAsyncOutputStream_BeginCancelBeginOutputRead()
{
using (AnonymousPipeServerStream pipeWrite = new AnonymousPipeServerStream(PipeDirection.Out, HandleInheritability.Inheritable))
Expand Down Expand Up @@ -345,7 +345,7 @@ async private Task<bool> WaitPipeSignal(PipeStream pipe, int millisecond)
}

[SkipOnPlatform(TestPlatforms.Windows, "currently on Windows these operations async-over-sync on Windows")]
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public async Task ReadAsync_OutputStreams_Cancel_RespondsQuickly()
{
Process p = CreateProcessLong();
Expand Down Expand Up @@ -380,7 +380,7 @@ public async Task ReadAsync_OutputStreams_Cancel_RespondsQuickly()
}
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestSyncStreams()
{
const string expected = "This string should come as output";
Expand All @@ -397,7 +397,7 @@ public void TestSyncStreams()
p.WaitForExit(); // wait for event handlers to complete
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestEOFReceivedWhenStdInClosed()
{
// This is the test for the fix of https://github.com/dotnet/runtime/issues/19277.
Expand Down Expand Up @@ -452,7 +452,7 @@ public void TestEOFReceivedWhenStdInClosed()
p1.Dispose();
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestAsyncHalfCharacterAtATime()
{
var receivedOutput = false;
Expand Down Expand Up @@ -493,7 +493,7 @@ public void TestAsyncHalfCharacterAtATime()
}
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestManyOutputLines()
{
const int ExpectedLineCount = 144;
Expand Down Expand Up @@ -521,7 +521,7 @@ public void TestManyOutputLines()
Assert.Equal(ExpectedLineCount + 1, totalLinesReceived);
}

[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[InlineData(false)]
[InlineData(true)]
public void TestManyOutputLines_SynchronizingObject(bool invokeRequired)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Threading)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)

Check failure on line 527 in src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs#L527 

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs(527,21): error xUnit1008: (NETCORE_ENGINEERING_TELEMETRY=Build) Test data attribute should only be used on a Theory. Remove the test data, or add the Theory attribute to the test method. (https://xunit.net/xunit.analyzers/rules/xUnit1008)
Expand Down Expand Up @@ -562,7 +562,7 @@ public void TestManyOutputLines_SynchronizingObject(bool invokeRequired)
Assert.Equal(invokeRequired ? totalLinesReceived : 0, invokeCalled);
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[SkipOnCoreClr("Avoid asserts in FileStream.Read when concurrently disposed", ~RuntimeConfiguration.Release)]
public void TestClosingStreamsAsyncDoesNotThrow()
{
Expand All @@ -581,7 +581,7 @@ public void TestClosingStreamsAsyncDoesNotThrow()
RemotelyInvokable.FireClosedEvent();
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestClosingStreamsUndefinedDoesNotThrow()
{
Process p = CreateProcessPortable(RemotelyInvokable.WriteLinesAfterClose);
Expand All @@ -593,7 +593,7 @@ public void TestClosingStreamsUndefinedDoesNotThrow()
RemotelyInvokable.FireClosedEvent();
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestClosingSyncModeDoesNotCloseStreams()
{
Process p = CreateProcessPortable(RemotelyInvokable.WriteLinesAfterClose);
Expand All @@ -612,7 +612,7 @@ public void TestClosingSyncModeDoesNotCloseStreams()
error.ReadToEnd();
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestStreamNegativeTests()
{
{
Expand Down Expand Up @@ -661,7 +661,7 @@ public void TestStreamNegativeTests()
}
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestCustomStandardInputEncoding()
{
var process = CreateProcessPortable(RemotelyInvokable.ReadLineWithCustomEncodingWriteLineWithUtf8, Encoding.UTF32.WebName);
Expand All @@ -682,7 +682,7 @@ public void TestCustomStandardInputEncoding()
Assert.Equal(RemotelyInvokable.SuccessExitCode, process.ExitCode);
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void TestMismatchedStandardInputEncoding()
{
var process = CreateProcessPortable(RemotelyInvokable.ReadLineWithCustomEncodingWriteLineWithUtf8, Encoding.UTF32.WebName);
Expand Down
2 changes: 1 addition & 1 deletion ...libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void ProcessId_Idempotent()
Assert.Equal(Environment.ProcessId, Environment.ProcessId);
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
// [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void ProcessId_MatchesExpectedValue()

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Threading)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)

Check failure on line 84 in src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs#L84 

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs(84,21): error xUnit1013: (NETCORE_ENGINEERING_TELEMETRY=Build) Public method 'ProcessId_MatchesExpectedValue' on test class 'EnvironmentTests' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. (https://xunit.net/xunit.analyzers/rules/xUnit1013)
{
using RemoteInvokeHandle handle = RemoteExecutor.Invoke(() => Console.WriteLine(Environment.ProcessId), new RemoteInvokeOptions { StartInfo = new ProcessStartInfo { RedirectStandardOutput = true } });
Expand Down

0 comments on commit b0e6945

Please sign in to comment.