Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Stephen Toub <stoub@microsoft.com>
  • Loading branch information
benaadams and stephentoub committed Jan 20, 2021
1 parent 9790c20 commit c47a557
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2749,7 +2749,7 @@ private unsafe void SendManifest(byte[]? rawManifest)
}

// Helper to deal with the fact that the type we are reflecting over might be loaded in the ReflectionOnly context.
// When that is the case, we have the build the custom assemblies on a member by hand.
// When that is the case, we have to build the custom assemblies on a member by hand.
internal static bool IsCustomAttributeDefinedHelper(
MemberInfo member,
Type attributeType,
Expand All @@ -2759,7 +2759,7 @@ internal static bool IsCustomAttributeDefinedHelper(
// System.Diagnostics.Tracing EventSource to be considered valid. This should not mattter anywhere but in Microsoft.Diagnostics.Tracing (nuget package).
if (!member.Module.Assembly.ReflectionOnly && (flags & EventManifestOptions.AllowEventSourceOverride) == 0)
{
// Let the runtime to the work for us, since we can execute code in this context.
// Let the runtime do the work for us, since we can execute code in this context.
return member.IsDefined(attributeType, inherit: false);
}

Expand Down Expand Up @@ -2789,7 +2789,7 @@ internal static bool IsCustomAttributeDefinedHelper(
// System.Diagnostics.Tracing EventSource to be considered valid. This should not mattter anywhere but in Microsoft.Diagnostics.Tracing (nuget package).
if (!member.Module.Assembly.ReflectionOnly && (flags & EventManifestOptions.AllowEventSourceOverride) == 0)
{
// Let the runtime to the work for us, since we can execute code in this context.
// Let the runtime do the work for us, since we can execute code in this context.
return member.GetCustomAttribute(attributeType, inherit: false);
}

Expand Down

0 comments on commit c47a557

Please sign in to comment.