changes to use const for stack alloc comparison

dotnet · Jun 11, 2024 · d275019 · d275019
1 parent 66774f7
commit d275019
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/...braries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs b/...braries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
@@ -522,7 +522,7 @@ public void CopyTo(scoped TensorSpan<T> destination)
             {
                 scoped Span<nint> curIndexes;
                 nint[]? curIndexesArray;
-                if (Rank > 5)
+                if (Rank > TensorSpan.MaxRankForStackAlloc)
                 {
                     curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                     curIndexes = curIndexesArray;
@@ -569,7 +569,7 @@ public bool TryCopyTo(scoped TensorSpan<T> destination)
             {
                 scoped Span<nint> curIndexes;
                 nint[]? curIndexesArray;
-                if (Rank > 5)
+                if (Rank > TensorSpan.MaxRankForStackAlloc)
                 {
                     curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                     curIndexes = curIndexesArray;
@@ -653,7 +653,7 @@ public ReadOnlyTensorSpan<T> Slice(params scoped ReadOnlySpan<NRange> ranges)
 
             scoped Span<nint> lengths;
             scoped Span<nint> offsets;
-            if (Rank > 5)
+            if (Rank > TensorSpan.MaxRankForStackAlloc)
             {
                 lengths = stackalloc nint[Rank];
                 offsets = stackalloc nint[Rank];
@@ -692,7 +692,7 @@ public bool TryFlattenTo(scoped Span<T> destination)
             {
                 scoped Span<nint> curIndexes;
                 nint[]? curIndexesArray;
-                if (Rank > 5)
+                if (Rank > TensorSpan.MaxRankForStackAlloc)
                 {
                     curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                     curIndexes = curIndexesArray;
@@ -733,7 +733,7 @@ public void FlattenTo(scoped Span<T> destination)
 
             scoped Span<nint> curIndexes;
             nint[]? curIndexesArray;
-            if (Rank > 5)
+            if (Rank > TensorSpan.MaxRankForStackAlloc)
             {
                 curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                 curIndexes = curIndexesArray;

diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs
@@ -505,7 +505,7 @@ public void Clear()
         {
             scoped Span<nint> curIndexes;
             nint[]? curIndexesArray;
-            if (Rank > 5)
+            if (Rank > TensorSpan.MaxRankForStackAlloc)
             {
                 curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                 curIndexes = curIndexesArray;
@@ -570,7 +570,7 @@ public void CopyTo(scoped TensorSpan<T> destination)
 
             scoped Span<nint> curIndexes;
             nint[]? curIndexesArray;
-            if (Rank > 5)
+            if (Rank > TensorSpan.MaxRankForStackAlloc)
             {
                 curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                 curIndexes = curIndexesArray;
@@ -613,7 +613,7 @@ public bool TryCopyTo(scoped TensorSpan<T> destination)
             {
                 scoped Span<nint> curIndexes;
                 nint[]? curIndexesArray;
-                if (Rank > 5)
+                if (Rank > TensorSpan.MaxRankForStackAlloc)
                 {
                     curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                     curIndexes = curIndexesArray;
@@ -703,7 +703,7 @@ public TensorSpan<T> Slice(params scoped ReadOnlySpan<NRange> ranges)
 
             scoped Span<nint> lengths;
             scoped Span<nint> offsets;
-            if (Rank > 5)
+            if (Rank > TensorSpan.MaxRankForStackAlloc)
             {
                 lengths = stackalloc nint[Rank];
                 offsets = stackalloc nint[Rank];
@@ -745,7 +745,7 @@ public bool TryFlattenTo(scoped Span<T> destination)
             {
                 scoped Span<nint> curIndexes;
                 nint[]? curIndexesArray;
-                if (Rank > 5)
+                if (Rank > TensorSpan.MaxRankForStackAlloc)
                 {
                     curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                     curIndexes = curIndexesArray;
@@ -786,7 +786,7 @@ public void FlattenTo(scoped Span<T> destination)
 
             scoped Span<nint> curIndexes;
             nint[]? curIndexesArray;
-            if (Rank > 5)
+            if (Rank > TensorSpan.MaxRankForStackAlloc)
             {
                 curIndexesArray = ArrayPool<nint>.Shared.Rent(Rank);
                 curIndexes = curIndexesArray;

diff --git a/...aries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpanExtensions.cs b/...aries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpanExtensions.cs
@@ -12,6 +12,8 @@ namespace System.Numerics.Tensors
 {
     public static class TensorSpan
     {
+        internal const int MaxRankForStackAlloc = 5;
+
         #region SequenceEqual
         /// <summary>
         /// Determines whether two sequences are equal by comparing the elements using IEquatable{T}.Equals(T).