Skip to content

Commit

Permalink
[wasm] CI: fix the new runtime-wasm-dbgtests pipeline (#81513)
Browse files Browse the repository at this point in the history
* [wasm] CI: fix the new runtime-wasm-dbgtests pipeline

* update README

* fix

* runtime-wasm-dbgtests: disable automatic run for PRs also
  • Loading branch information
radical authored Feb 2, 2023
1 parent 873775b commit ddba2aa
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 40 deletions.
2 changes: 1 addition & 1 deletion eng/pipelines/common/variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ variables:
- name: isNotExtraPlatformsBuild
value: ${{ ne(variables['Build.DefinitionName'], 'runtime-extra-platforms') }}
- name: isWasmOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests') }}
value: ${{ in(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-wasm-dbgtests') }}
- name: isiOSLikeOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-ioslike') }}
- name: isiOSLikeSimulatorOnlyBuild
Expand Down
14 changes: 8 additions & 6 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ parameters:
isRollingBuild: false
excludeLibTests: false
excludeNonLibTests: false
debuggerTestsOnly: false

jobs:

Expand Down Expand Up @@ -61,7 +62,7 @@ jobs:
# - run everything, if relevant paths changed
# - For runtime-wasm, force run all the jobs
#
- ${{ if and(ne(parameters.isRollingBuild, true), ne(parameters.excludeLibTests, true)) }}:
- ${{ if and(ne(parameters.isRollingBuild, true), ne(parameters.excludeLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
# Library tests
# these run on runtime also
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
Expand Down Expand Up @@ -175,7 +176,7 @@ jobs:
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
alwaysRun: ${{ parameters.isWasmOnlyBuild }}

- ${{ if and(ne(parameters.isRollingBuild, true), ne(parameters.excludeNonLibTests, true)) }}:
- ${{ if and(ne(parameters.isRollingBuild, true), ne(parameters.excludeNonLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
# Wasm.Build.Tests
- template: /eng/pipelines/common/templates/wasm-build-tests.yml
parameters:
Expand All @@ -185,19 +186,20 @@ jobs:
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}

# Debugger tests
- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
- template: /eng/pipelines/common/templates/wasm-runtime-tests.yml
parameters:
platforms:
- browser_wasm
- browser_wasm_win
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}

- template: /eng/pipelines/common/templates/wasm-runtime-tests.yml
- ${{ if and(ne(parameters.isRollingBuild, true), or(ne(parameters.excludeNonLibTests, true), eq(parameters.debuggerTestsOnly, true))) }}:
# Debugger tests
- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
parameters:
platforms:
- browser_wasm
- browser_wasm_win
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}

Expand Down
49 changes: 16 additions & 33 deletions eng/pipelines/runtime-wasm-dbgtests.yml
Original file line number Diff line number Diff line change
@@ -1,41 +1,24 @@
trigger: none
pr: none

variables:
- template: /eng/pipelines/common/variables.yml

jobs:

#
# Evaluate paths
#
- template: /eng/pipelines/common/evaluate-default-paths.yml

# Debugger tests
- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
extends:
template: /eng/pipelines/common/templates/pipeline-with-resources.yml
parameters:
platforms:
- Browser_wasm
- Browser_wasm_win
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
stages:
- stage: Build
jobs:

- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
parameters:
platforms:
- Browser_wasm
- Browser_wasm_win
extraBuildArgs: /p:MonoWasmBuildVariant=multithread /p:WasmEnableThreads=true
nameSuffix: DebuggerTests_MultiThreaded
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
#
# Evaluate paths
#
- template: /eng/pipelines/common/evaluate-default-paths.yml

- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
parameters:
platforms:
- Browser_wasm_firefox
browser: firefox
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
# ff tests are unstable currently
shouldContinueOnError: true
- template: /eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
parameters:
isExtraPlatformsBuild: ${{ variables.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ variables.isWasmOnlyBuild }}
isRollingBuild: ${{ variables.isRollingBuild }}
debuggerTestsOnly: true
2 changes: 2 additions & 0 deletions src/mono/wasm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ npm update --lockfile-version=1
* `runtime-extra-platforms` does not run any wasm jobs on PRs
* `high resource aot` runs a few specific library tests with AOT, that require more memory to AOT.

* `runtime-wasm-dbgtests` runs all the debugger test jobs

## Rolling build (twice a day):

* `runtime` runs all the wasm jobs, but `AOT` still only runs smoke tests.
Expand Down

0 comments on commit ddba2aa

Please sign in to comment.