Skip to content

Commit

Permalink
Fix assert in BaseBucketParamsManager (#95911)
Browse files Browse the repository at this point in the history
The assert was breaking couple of MDBG diagnostic tests. The modulePath
was empty in that case and modulePath.IsNormalized() was returning
false.
  • Loading branch information
janvorli authored Dec 12, 2023
1 parent d636522 commit f1d5cea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/coreclr/vm/dwbucketmanager.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ bool BaseBucketParamsManager::GetFileVersionInfoForModule(Module* pModule, USHOR
if (!succeeded)
{
const SString& modulePath = pPEAssembly->GetPath();
_ASSERTE(modulePath.IsNormalized());
_ASSERTE(modulePath.IsEmpty() || modulePath.IsNormalized());
succeeded = !modulePath.IsEmpty() && SUCCEEDED(DwGetFileVersionInfo(modulePath.GetUnicode(), major, minor, build, revision));
}
}
Expand Down

0 comments on commit f1d5cea

Please sign in to comment.