-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[browser][bindings] Fix error with SharedArrayBuffer when used as a b…
…acking view. (#46625) * Add code to check for a backing ArrayBuffer as well as a backing SharedBuffer. - Resolves the error `"Object '...' is not a typed array"` * Add other Slice methods per documentation of JavaScript docs - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer/slice * Add tests for SharedArrayBuffer. * Address review comment about unused usings * Address review comments. * Address review comments for unnecessary mod in commit * Add back whitespace * Modify comment description as per review comment * Address support for SharedArrayBuffer which fails under Firefox. * Revert "Address support for SharedArrayBuffer which fails under Firefox." This reverts commit f817638. * Address support for SharedArrayBuffer which fails under Firefox. Without all the whitespace changes.
- Loading branch information
Showing
4 changed files
with
183 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
156 changes: 156 additions & 0 deletions
156
...ices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Collections.Generic; | ||
| using Xunit; | ||
|
|
||
| namespace System.Runtime.InteropServices.JavaScript.Tests | ||
| { | ||
| public static class SharedArrayBufferTests | ||
| { | ||
| private static Function _objectPrototype; | ||
|
|
||
| public static IEnumerable<object[]> Object_Prototype() | ||
| { | ||
| _objectPrototype ??= new Function("return Object.prototype.toString;"); | ||
| yield return new object[] { _objectPrototype.Call() }; | ||
| } | ||
|
|
||
| [Theory] | ||
| [MemberData(nameof(Object_Prototype))] | ||
| public static void SharedArrayBuffer_NonZeroLength(Function objectPrototype) | ||
| { | ||
| SharedArrayBuffer d = new SharedArrayBuffer(50); | ||
| Assert.Equal("[object SharedArrayBuffer]", objectPrototype.Call(d)); | ||
| Assert.Equal(50, d.ByteLength); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBufferSlice() | ||
| { | ||
| SharedArrayBuffer d = new SharedArrayBuffer(50); | ||
| Assert.Equal(50, d.Slice().ByteLength); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBuffer_Slice_BeginEndForFullArray() | ||
| { | ||
| SharedArrayBuffer d = new SharedArrayBuffer(50); | ||
| Assert.Equal(50, d.Slice(0, 50).ByteLength); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBuffer_Slice_BeginZero() | ||
| { | ||
| SharedArrayBuffer d = new SharedArrayBuffer(50); | ||
| Assert.Equal(50, d.Slice(0).ByteLength); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBuffer_Slice_BeginNegative() | ||
| { | ||
| SharedArrayBuffer d = new SharedArrayBuffer(50); | ||
| Assert.Equal(3, d.Slice(-3).ByteLength); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBuffer_Slice_BeginEndSubset() | ||
| { | ||
| SharedArrayBuffer d = new SharedArrayBuffer(50); | ||
| Assert.Equal(3, d.Slice(1, 4).ByteLength); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBufferSliceAndDice() | ||
| { | ||
| // create a SharedArrayBuffer with a size in bytes | ||
| SharedArrayBuffer buffer = new SharedArrayBuffer(16); | ||
| Int32Array int32View = new Int32Array(buffer); // create view | ||
| // produces Int32Array [0, 0, 0, 0] | ||
|
|
||
| int32View[1] = 42; | ||
|
|
||
| Assert.Equal(4, int32View.Length); | ||
| Assert.Equal(42, int32View[1]); | ||
|
|
||
| Int32Array sliced = new Int32Array(buffer.Slice(4,12)); | ||
| // expected output: Int32Array [42, 0] | ||
|
|
||
| Assert.Equal(2, sliced.Length); | ||
| Assert.Equal(42, sliced[0]); | ||
| Assert.Equal(0, sliced[1]); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void SharedArrayBufferSliceAndDiceAndUseThroughSpan() | ||
| { | ||
| // create a SharedArrayBuffer with a size in bytes | ||
| SharedArrayBuffer buffer = new SharedArrayBuffer(16); | ||
| Int32Array int32View = new Int32Array(buffer); // create view | ||
| // produces Int32Array [0, 0, 0, 0] | ||
|
|
||
| int32View[1] = 42; | ||
|
|
||
| Assert.Equal(4, int32View.Length); | ||
| Assert.Equal(42, int32View[1]); | ||
|
|
||
| Int32Array sliced = new Int32Array(buffer.Slice(4,12)); | ||
| // expected output: Int32Array [42, 0] | ||
|
|
||
| Span<int> nativeArray = sliced; | ||
|
|
||
| int sum = 0; | ||
| for (int i = 0; i < nativeArray.Length; i++) | ||
| { | ||
| sum += nativeArray[i]; | ||
| } | ||
|
|
||
| Assert.Equal(42, sum); | ||
| } | ||
|
|
||
| [Theory] | ||
| [MemberData(nameof(GetTestData), 16)] | ||
| public static void SharedArrayBufferSliceAndDice3_Subset(SharedArrayBuffer buffer) | ||
| { | ||
| Int32Array sliced = new Int32Array(buffer.Slice(4,12)); | ||
|
|
||
| Assert.Equal(2, sliced.Length); | ||
| Assert.Equal(42, sliced[0]); | ||
| Assert.Equal(12, sliced[1]); | ||
| } | ||
|
|
||
| [Theory] | ||
| [MemberData(nameof(GetTestData), 16)] | ||
| public static void SharedArrayBufferSliceAndDice3_SubsetFromTheBack(SharedArrayBuffer buffer) | ||
| { | ||
| Int32Array sliced = new Int32Array(buffer.Slice(-4)); | ||
|
|
||
| Assert.Equal(1, sliced.Length); | ||
| Assert.Equal(13, sliced[0]); | ||
| } | ||
|
|
||
| [Theory] | ||
| [MemberData(nameof(GetTestData), 16)] | ||
| public static void SharedArrayBufferSliceAndDice3_SubsetFromTheBackWithEnd(SharedArrayBuffer buffer) | ||
| { | ||
| Int32Array sliced = new Int32Array(buffer.Slice(-12, -4)); | ||
|
|
||
| Assert.Equal(2, sliced.Length); | ||
| Assert.Equal(42, sliced[0]); | ||
| Assert.Equal(12, sliced[1]); | ||
| } | ||
|
|
||
| private static TheoryData<SharedArrayBuffer> GetTestData(int length) | ||
| { | ||
| // create a SharedArrayBuffer with a size in bytes | ||
| SharedArrayBuffer buffer = new SharedArrayBuffer(length); | ||
| Int32Array int32View = new Int32Array(buffer); // create view | ||
| for (int i = 0; i < int32View.Length; i ++) | ||
| int32View[i] = i + 10; | ||
|
|
||
| int32View[1] = 42; | ||
| return new TheoryData<SharedArrayBuffer> { buffer }; | ||
| } | ||
|
|
||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters