Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/Sve Test: Inputs for LoadVector API test #101475

Closed
kunalspathak opened this issue Apr 24, 2024 · 6 comments · Fixed by #106449
Closed

Arm64/Sve Test: Inputs for LoadVector API test #101475

kunalspathak opened this issue Apr 24, 2024 · 6 comments · Fixed by #106449
Assignees
@a74nh
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@kunalspathak
Copy link
Member

kunalspathak commented Apr 24, 2024 •
edited
Loading

From the discussion at #101291 (comment), we should make sure that we use some decent mask values in LoadVector and StoreVector APIs to exercise and test the functionality of these APIs.

  • A mask containing mix of 0s and 1s
  • A mask containing all 0s
  • A mask containing all 1s
  • Non-faulting should never throw exception even if invalid address such as 0x0 is passed to LoadVector.
  • Faulting APIs throws exception when invalid address such as 0x0 is passed to LoadVector.
  • In faulting APIs, inactive elements do not throw exception when invalid address is given to it.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 24, 2024
@kunalspathak kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 24, 2024
@kunalspathak
Copy link
Member Author

cc: @dotnet/arm64-contrib

@kunalspathak kunalspathak mentioned this issue Apr 24, 2024
Merged
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 25, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Apr 26, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 26, 2024
@kunalspathak kunalspathak added the Priority:2 Work that is important, but not critical for the release label May 3, 2024
This was referenced May 16, 2024
Merged
Merged
@kunalspathak kunalspathak removed the Priority:2 Work that is important, but not critical for the release label Jun 24, 2024
@kunalspathak
Copy link
Member Author

@a74nh @SwapnilGaikwad PTAL for .NET 9

@a74nh a74nh added the Priority:2 Work that is important, but not critical for the release label Jul 30, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

priority:2 for RC1 snap : Missing testing. However it's at the lower end compared to the other testing issues. There's always a chance of the existing testing using all 1s or all 0s etc. If there is a functionality issue we'd have probably spotted it by now. However, there is still a chance we might not have.

@mikabl-arm
Copy link
Contributor

I'll work on this.

@a74nh a74nh self-assigned this Aug 9, 2024
@a74nh
Copy link
Contributor

a74nh commented Aug 9, 2024

Assigning to my on behalf of @mikabl-arm

mikabl-arm added a commit to mikabl-arm/dotnet-runtime that referenced this issue Aug 15, 2024
@mikabl-arm
Arm64/Sve Test: test randomized masks for LoadVector APIs (dotnet#101475
d320801 
)
@mikabl-arm mikabl-arm mentioned this issue Aug 15, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 15, 2024
amanasifkhalid pushed a commit that referenced this issue Aug 16, 2024
@mikabl-arm
Arm64/Sve Test: test randomized masks for LoadVector APIs (#101475) (#…
239fad9 
…106449)
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a74nh a74nh

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Arm64/Sve Test: test randomized masks for LoadVector APIs (#101475) mikabl-arm/dotnet-runtime
5 participants
@a74nh @jeffschwMSFT @kunalspathak @JulieLeeMSFT @mikabl-arm