-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Diagnostics.Tests.ProcessTests.MaxWorkingSet_GetNotStarted wrong exception code on BSD-ish systems #105422
Labels
area-System.Diagnostics.Process
in-pr
There is an active PR which will close this issue when it is merged
needs-further-triage
Issue has been initially triaged, but needs deeper consideration or reconsideration
Milestone
Comments
dotnet-policy-service
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Jul 24, 2024
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
This was referenced Jul 24, 2024
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 24, 2024
Is this not getting skipped correctly?
|
Maybe not? Or maybe I exposed it for the SunOS port. |
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 25, 2024
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 25, 2024
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 27, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Comment out those tests for now and add notes. Needs testing on the affected platforms and then either update those commented out tests or just remove them.
jeffhandley
added
needs-further-triage
Issue has been initially triaged, but needs deeper consideration or reconsideration
and removed
untriaged
New issue has not been triaged by the area owner
labels
Jul 27, 2024
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 27, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Comment out those tests for now and add notes. Needs testing on the affected platforms and then either update those commented out tests or just remove them.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 27, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Comment out those tests for now and add notes. Needs testing on the affected platforms and then either update those commented out tests or just remove them.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 27, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Comment out those tests for now and add notes. Needs testing on the affected platforms and then either update those commented out tests or just remove them.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 27, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Comment out those tests for now and add notes. Needs testing on the affected platforms and then either update those commented out tests or just remove them.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 28, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Comment out those tests for now and add notes. Needs testing on the affected platforms and then either update those commented out tests or just remove them.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 28, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (pretty much any port using ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. There are tests that verify the old (less correct) behavior of the get/set WorkingSet methods from before this fix. Still trying to get those sorted out...
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 29, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 29, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Jul 30, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 18, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
dotnet-policy-service
bot
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Aug 18, 2024
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 18, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 18, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 21, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 21, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 21, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 21, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 21, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
gwr
added a commit
to gwr/dotnet-runtime
that referenced
this issue
Aug 22, 2024
Fixes issue dotnet#105422 On MacOS, FreeBSD, SunOS (the ports that share ProcessBSD.c) the get/set WorkingSet methods only work on the current process. Skip the parts of tests that operate on other processes. Remove now redundant MacOS-speicifc tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-System.Diagnostics.Process
in-pr
There is an active PR which will close this issue when it is merged
needs-further-triage
Issue has been initially triaged, but needs deeper consideration or reconsideration
Description
In the SunOS port I'm working on (See #105403)
I'm sharing this file
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.BSD.cs
with FreeBSD, OSX, etc.
During my testing I discovered a bug and have a fix to suggest.
The bug is that for a new Process object (for which there is no Unix process ID started yet)
the calls to
GetWorkingSetLimits
andSetWorkingSetLimits
are meant to throwSystem.InvalidOperationException
but they throwSystem.PlatformNotSupportedException
instead. Here's the test output:Same for
MinWorkingSet
Reproduction Steps
Run the
System.Diagnostics.Process
tests and look for these failures:Expected behavior
These should pass.
Actual behavior
They fail as shown above.
Regression?
no
Known Workarounds
Disable those tests, or add this suggested fix:
Configuration
Sorry for the minimal detail here, but the file involved currently affects: FreeBSD, OSX
(and when I'm further along, SunOS).
Other information
No response
The text was updated successfully, but these errors were encountered: