Issue with QuoteSnippetStringCStyle when parsing '\u0085' character

[hamarb123]

Another line needs to be added after this, which would be

case '\u0085':

This is because it is recognised as a newline character in C# (see here), which cannot be in literal strings.
If the CSharpCodeGenerator class was used to make code with a string in it that has U+0085 in it, it would generate invalid C# code.
NB: this is also an issue on the .NET Framework (see here)

I would like to implement this change, thanks!

[GrabYourPitchforks]

Thanks for reporting this! Your reasoning seems sound to me. Feel free to look through our contribution guidelines then send a PR with your proposed fix. Remember also to update any appropriate unit tests to validate your change

[hamarb123]

@GrabYourPitchforks, what sort of a test would I need, a test that checks if a class with a string in it has the correct contents when the string has newline characters in it? Also, where should I put the test? Maybe in here?
Like this:

[Fact]
public void SpecialNewLineCharactersInStringsDoneCorrectly()
{
    var cd = new CodeTypeDeclaration("ClassWithStringFields") { IsClass = true };

    var field = new CodeMemberField("System.String", "StringWithSpecialNewLines");
    field.Attributes = MemberAttributes.Public | MemberAttributes.Static;
    field.InitExpression = new CodePrimitiveExpression("\u0085\u2028\u2029");
    cd.Members.Add(field);

    AssertEqual(cd,
        @"public class ClassWithStringFields {
              public static string StringWithSpecialNewLines = ""\u0085\u2028\u2029"";
          }");
 }

Is there anything that I should rename?
Thank you.

[GrabYourPitchforks]

That looks like a fine test. The area owners might have further feedback regarding naming once you submit the PR.

[hamarb123]

The PR is at #1853

[hamarb123]

This has now been solved, see PR #1853.