Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Projects don't take architecture into account #20321

Closed
MattGal opened this issue Feb 24, 2017 · 4 comments · Fixed by #41666
Closed

Deployment Projects don't take architecture into account #20321

MattGal opened this issue Feb 24, 2017 · 4 comments · Fixed by #41666

Comments

@MattGal
Copy link
Member

MattGal commented Feb 24, 2017

This isn't causing trouble right now, but was something I noticed in the course of other investigations. On a machine building multiple different verticals without cleaning, this could cause clashes / mismatches.

If you review a build log where this happens, you see stuff like:
E:\A\_work\89\s\corefx\packages\runtime.win7-x86.Microsoft.NETCore.Runtime.CoreCLR\2.0.0-beta-25021-03\runtimes\win7-x86\native\sos.dll (runtime.win7-x86.Microsoft.NETCore.Runtime.CoreCLR.2.0.0-beta-25021-03) -> E:\A\_work\89\s\corefx\bin\Windows_NT.AnyCPU.Debug\runtime\netcoreapp\sos.dll

but, we use the same output path for x64 as well. It would be useful for this to take into consideration the Arch of what's being copied when generating layouts like this.

@weshaggard weshaggard changed the title Dependency Projects don't take architecture into account Deployment Projects don't take architecture into account Feb 24, 2017
@weshaggard weshaggard self-assigned this Feb 24, 2017
@weshaggard weshaggard removed their assignment Nov 5, 2018
@weshaggard
Copy link
Member

@ericstj looks like something we might still need to consider cleaning up.

@ericstj
Copy link
Member

ericstj commented Nov 5, 2018

Yeah, this is a generic problem when using configuration. I'd prefer we don't use outdir at all for these, nor try to build them incrementally. We should always be doing the up-to-date check between source dir from package and bin-placed location.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@ViktorHofer
Copy link
Member

@ericstj your domain, I assume this is about depprojs? If yes then I think we can close this.

@ericstj
Copy link
Member

ericstj commented Apr 17, 2020

The problem here is that runtime.depproj copies architecture specific bits, but it's outdir does not include architecture. I looked at a binlog for this project and it seems OutDir is the only Copy destination that doesn't have arch. We should either add Arch to the out and intermediate dirs for runtime.depproj or just disable copying to outdir.

Better yet if we can just delete runtime.depproj and have the coreclr subset copy things to the paths we expect in libraries.

@ViktorHofer ViktorHofer modified the milestones: Future, 5.0.0 Jun 23, 2020
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2020
@ViktorHofer ViktorHofer modified the milestones: 5.0.0, Future Jul 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants