Remove multi-targeting from runtime.depproj #41666
Conversation
and convert it to a csproj and use the NoBuild msbuild sdk. Simplify the project logic in relation to IL vs native code as well.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @safern, @ViktorHofer |
src/libraries/Externals.csproj
Outdated
| <SwapNativeForIL Condition="'$(SwapNativeForIL)' == '' and ('$(Configuration)' == 'Debug' or '$(Coverage)' == 'true') and '$(RuntimeFlavor)' != 'Mono'">true</SwapNativeForIL> | ||
| <TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks> |
There was a problem hiding this comment.
Will we run into clashing when folks run different vertical builds? Like building for browser and unix from same clone?
There was a problem hiding this comment.
I just verified this scenario, the outputs aren't clashing:
The Browser leaf contains the mono aot stuff and the Linux leaf contians the host and other stuff that isn't present on wasm.
|
Merging to unblock the planned SDK update. Verified that what @ericstj pointed out isn't a concern. |
|
/azp run runtime |
|
/azp run runtime-live-build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Remove multi-targeting from runtime.depproj and convert it to a csproj and use the NoBuild msbuild sdk. Simplify the project logic in relation to IL vs native code as well.
ghost
locked as resolved and limited conversation to collaborators
and convert it to a csproj and use the NoBuild msbuild sdk. Simplify the
project logic in relation to IL vs native code as well.
Fixes #40778
Fixes #20321
Contributes to #38034
also fixes a reported issue when updating to a newer SDK >= RC1:
This the short term fix which removes the depproj infrastructure. The long term fix will remove externals.csproj entirely and use live built assets for the host assets.