-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LongContinuationChain_ContinueWith_DoesNotStackOverflow test failing on Mono in CI #2084
Comments
ps I love that mono output a stack trace here for the stack overflow. @janvorli, have we made any progress on being able to do something similar in coreclr? |
#2097 disabled this. |
I have had a local experimental change that can generate output like this for quite some time. However, there was a discussion about a need to shorten the trace in some way (finding repeating segments and dumping them once e.g. with a repeat count, dumping just part of the trace, etc.) so that we don't end up dumping. I wanted to figure out a way to do that that would cover non-trivial cases too (imagine a recursive loop within other recursive loop kind of things), but then I got distracted by other work of higher priority and it went out of my radar. So thank you for asking. Let me get back to that and finalize the change. I'll probably do something easy, like a single repeating pattern detection and leave more involved improvements for later. |
Thanks, Jan. |
I have moved this test out of CoreFX.issues.rsp file in #2087, but because it's still flaky, I'm reopening this issue and will refer to it as |
Moving to 7.0.0 |
haven't seen recent failures. We'll keep it open, move to 8.0.0 milestone and triage the disabled-test issues next month. |
- Re-enable disabled tests tracked by dotnet#1417 and dotnet#2084 - Make stack size configurable on NAOT via `IlcDefaultStackSize` on Windows
The test TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow that's validating that continuation chains don't stack overflow is stack overflowing when run on Mono on macOS (maybe elsewhere, too). I've not debugged through it, but my guess would be that something is awry with
runtime/src/mono/mono/metadata/icall.c
Line 1307 in cd622cd
runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Lines 3231 to 3233 in 81f5310
cc: @akoeplinger
The text was updated successfully, but these errors were encountered: