Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ManagedHandler] Should do request validation before connecting #24853

Closed
geoffkizer opened this issue Jan 31, 2018 · 0 comments
Closed

[ManagedHandler] Should do request validation before connecting #24853

geoffkizer opened this issue Jan 31, 2018 · 0 comments
Assignees
Milestone

Comments

@geoffkizer
Copy link
Contributor

There is some minor request validation that we do at the beginning of HttpConnection.SendAsync. This validation can cause us to throw NotSupportedException in some rare cases.

We should do this validation earlier in the request processing. At this point, we've already established a connection (or pulled one from the pool), and throwing here will cause the connection to be torn down unnecessarily.

@stephentoub stephentoub self-assigned this Feb 1, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants