Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the PInvoke analyzer from runtime repo build #33867

Closed
tarekgh opened this issue Mar 20, 2020 · 2 comments · Fixed by #38550
Closed

Remove the PInvoke analyzer from runtime repo build #33867

tarekgh opened this issue Mar 20, 2020 · 2 comments · Fixed by #38550
Labels
area-Infrastructure-libraries
Milestone
5.0.0

Comments

@tarekgh
Copy link
Member

tarekgh commented Mar 20, 2020

The brief discussion about that is here #33834 (review)
@tarekgh tarekgh added this to the 5.0 milestone Mar 20, 2020
@tarekgh tarekgh added the untriaged New issue has not been triaged by the area owner label Mar 20, 2020
@tarekgh tarekgh mentioned this issue Mar 20, 2020
Merged
@danmoseley
Copy link
Member

may be just roughly reverting dotnet/corefx#16704

@danmoseley danmoseley mentioned this issue Mar 25, 2020
Merged
danmoseley added a commit to stephentoub/runtime that referenced this issue Mar 25, 2020
@danmoseley
Locally disable pinvoke analyzer pending dotnet#33867
a79f3b1
akoeplinger pushed a commit that referenced this issue Mar 25, 2020
@stephentoub @danmoseley
Enable analyzers for mono/netcore (#34052)
7302fa4 
This is mostly just running auto-fixers for the various violated rules. In just a few places, I manually intervened.

* Locally disable pinvoke analyzer pending #33867

Co-authored-by: Dan Moseley <danmose@microsoft.com>
@stephentoub stephentoub mentioned this issue Apr 1, 2020
Closed
@danmoseley
Copy link
Member

should also delete https://github.com/dotnet/runtime/blob/master/docs/coding-guidelines/pinvoke-checker.md

@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Apr 17, 2020
@stephentoub stephentoub mentioned this issue Jun 29, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Disable P/Invoke analyzer stephentoub/runtime
4 participants
@danmoseley @jkotas @ericstj @tarekgh