Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum CMake version to 3.14.5 #33976

Closed
akoeplinger opened this issue Mar 23, 2020 · 2 comments · Fixed by #34757
Closed

Set minimum CMake version to 3.14.5 #33976

akoeplinger opened this issue Mar 23, 2020 · 2 comments · Fixed by #34757
Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner

Comments

@akoeplinger
Copy link
Member

akoeplinger commented Mar 23, 2020

See discussion in 16e1d30#r396389297

The documented minimum CMake version is 3.15.5 already but a few places still check for 3.14:

$ git grep "_minimum_required\|3\.14\.2"  # search for _minimum_required OR 3.14.2

docs/workflow/requirements/linux-requirements.md:Building the repo requires CMake 3.14.2 or newer on Linux. Add Kitware's APT feed to your configuration for a newer version of CMake. See their instructions at <https://apt.kitware.com/>. Also, add LLVM/s APT feed to your configuration for a newer version of CMake. See their instructions as <http://apt.llvm.org/>.
eng/native/build-commons.sh:    if [[ "$(version "$cmake_version")" -lt "$(version 3.14.2)" ]]; then
eng/native/build-commons.sh:        echo "Please install CMake 3.14.2 or newer from http://www.cmake.org/download/ or https://apt.kitware.com and ensure it is on your path."; exit 1;
global.json:    "cmake": "3.14.2",
src/coreclr/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.2)
src/coreclr/src/pal/tests/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.2)
src/coreclr/tests/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.2)
src/installer/corehost/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.2)
src/installer/corehost/cli/test/mockhostfxr/CMakeLists.txt:cmake_minimum_required (VERSION 2.6)
src/libraries/Native/Unix/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.2)
src/libraries/Native/Windows/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.2)
src/libraries/Native/Windows/clrcompression/zlib/CMakeLists.txt:cmake_minimum_required(VERSION 2.4.4)
src/mono/CMakeLists.txt:cmake_minimum_required (VERSION 3.10)
src/mono/netcore/sample/iOS/CMakeLists.txt:cmake_minimum_required(VERSION 3.14.5)
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 23, 2020
@vcsjones
Copy link
Member

@jkoritzinsky wasn't there an issue with Alpine that prevented bumping the minimum CMake version to match documentation?

@jkoritzinsky
Copy link
Member

There was. We can't use 3.15.5 on Alpine because packages for Alpine 3.11 aren't backward-compatible with Alpine 3.10 and older. However, Alpine 3.10 ships with CMake 3.14.5, so this is doable.

monojenkins pushed a commit to monojenkins/mono that referenced this issue Apr 9, 2020
iOS requires 3.14.5 version and we have a special case for it. Since this is a minor version difference, and no distro is particularly providing cmake 3.14.2 package, it is safe to update to 3.14.5 to cover our supported platform matrix.

Discussion: dotnet/runtime#33959 (comment)
Fixes: dotnet/runtime#33976

cc @akoeplinger, @jkotas
akoeplinger added a commit that referenced this issue Jun 1, 2020
iOS requires 3.14.5 version and we have a special case for it. Since this is a minor version difference, and no distro is particularly providing cmake 3.14.2 package, it is safe to update to 3.14.5 to cover our supported platform matrix.

Discussion: #33959 (comment)
Fixes: #33976

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner
Projects
None yet
4 participants