Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Environment.GetFolderPath to be compatible with tvOS #34007

Closed
marek-safar opened this issue Mar 24, 2020 · 5 comments · Fixed by #57508
Closed

Change Environment.GetFolderPath to be compatible with tvOS #34007

marek-safar opened this issue Mar 24, 2020 · 5 comments · Fixed by #57508
Assignees
@directhex
Labels
area-System.Runtime blocking-release os-ios Apple iOS
Milestone
6.0.0

Comments

@marek-safar
Copy link
Contributor

As part of the mobile workloads migration, we need to ensure the apps are behaving consistently when calling into Environment.GetFolderPath. There is already some implementation for iOS but it looks like it's not fully compatible with existing Mono code

The second part is to ensure there is full code coverage for all SpecialFolder values.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Runtime untriaged New issue has not been triaged by the area owner labels Mar 24, 2020
@marek-safar marek-safar added this to the 5.0 milestone Mar 24, 2020
@marek-safar marek-safar added the os-ios Apple iOS label Mar 24, 2020
@marek-safar
Copy link
Contributor Author

/cc @EgorBo

@EgorBo EgorBo mentioned this issue Mar 24, 2020
Merged
@akoeplinger akoeplinger changed the title Change Environment.GetFolderPath to be compatible with iOS/tvOS Change Environment.GetFolderPath to be compatible with tvOS Nov 25, 2020
@akoeplinger
Copy link
Member

We still have an important TODO that needs to be fixed for tvOS:

runtime/src/mono/netcore/System.Private.CoreLib/src/System/Environment.iOS.cs

Lines 39 to 41 in f48c8d5

// TODO: fix for tvOS (https://github.com/dotnet/runtime/issues/34007)
// The "normal" NSDocumentDirectory is a read-only directory on tvOS
// and that breaks a lot of assumptions in the runtime and the BCL

Reopening to track that.

@akoeplinger akoeplinger reopened this Nov 25, 2020
@akoeplinger akoeplinger modified the milestones: 5.0.0, 6.0.0 Nov 25, 2020
@akoeplinger akoeplinger removed the untriaged New issue has not been triaged by the area owner label Nov 25, 2020
@marek-safar
Copy link
Contributor Author

@steveisok please assign

@filipnavara filipnavara mentioned this issue Aug 13, 2021
Merged
@directhex
Copy link
Contributor

It looks like NSCachesDirectory is the preferred alternative for tvOS.

Ref: firebase/firebase-ios-sdk#2777
Ref: https://developer.apple.com/forums/thread/19002

@akoeplinger
Copy link
Member

@directhex on the mono/mono version we've been using a subdirectory in NSLibraryDirectory: https://github.com/mono/mono/blob/main/mcs/class/corlib/System/Environment.iOS.cs#L21-L30

@akoeplinger akoeplinger assigned directhex and unassigned akoeplinger Aug 16, 2021
@directhex directhex mentioned this issue Aug 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 16, 2021
@directhex directhex mentioned this issue Aug 18, 2021
Closed
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2021
@directhex directhex mentioned this issue Aug 24, 2021
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Aug 24, 2021
@directhex directhex mentioned this issue Aug 27, 2021
Closed
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Aug 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@directhex directhex

Labels
area-System.Runtime blocking-release os-ios Apple iOS
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Give tvOS a special value for Personal/MyDocuments directhex/runtime
4 participants
@marek-safar @directhex @akoeplinger @Dotnet-GitSync-Bot