Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0-rc1] Give tvOS a special value for Personal/MyDocuments #58056

Merged
merged 1 commit into from
Aug 27, 2021
Merged

[release/6.0-rc1] Give tvOS a special value for Personal/MyDocuments #58056

merged 1 commit into from
Aug 27, 2021

Conversation

directhex
Copy link
Contributor

@directhex directhex commented Aug 24, 2021 •
edited by steveisok
Loading

Backport of #57508 to release/6.0-rc1

/cc @directhex

Customer Impact

Fixes two issues where tvOS devices have read-only directories which are read-write on other Apple platforms; SpecialFolders.Personal (and subdirectories thereof), and TMP.

Testing

Manual testing on Helix & local device

Risk

Low - makes minor changes to how temp folders are calculated on all iOS-like targets, which should be more futureproof if Apple stops allowing /tmp or TMP in an OS update

Fixes #34007
Fixes #57638

Backport of #57508 to release/6.0-rc1

@directhex directhex added the Servicing-consider Issue for next servicing release review label Aug 24, 2021
@ghost
Copy link

ghost commented Aug 24, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57508 to release/6.0-rc1

/cc @directhex

Customer Impact

Fixes two issues where tvOS devices have read-only directories which are read-write on other Apple platforms; SpecialFolders.Personal (and subdirectories thereof), and TMP.

Testing

Manual testing on Helix & local device (we don't CI on devices currently, and the issues are device-only)

Risk

Low - makes minor changes to how temp folders are calculated on all iOS-like targets, which should be more futureproof if Apple stops allowing /tmp or TMP in an OS update

Fixes #34007
Fixes #57638

Backport of #57508 to release/6.0-rc1

Author: directhex
Assignees: -
Labels:

Servicing-consider, area-System.Runtime
Milestone: -

@danmoseley danmoseley added the os-tvos Apple tvOS label Aug 26, 2021
@danmoseley danmoseley requested a review from akoeplinger August 26, 2021 17:56
@Anipik Anipik added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 27, 2021
@Anipik
Copy link
Contributor

Anipik commented Aug 27, 2021

approved offline

@Anipik Anipik merged commit 8da82f2 into dotnet:release/6.0-rc1 Aug 27, 2021
@directhex
Copy link
Contributor Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1175313005

@github-actions github-actions bot mentioned this pull request Aug 27, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@Anipik Anipik Anipik approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-System.Runtime os-tvos Apple tvOS Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@directhex @Anipik @danmoseley