Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI net472 leg failure: 'Target frameworks need to be updated' #34216

Closed
maryamariyan opened this issue Mar 27, 2020 · 1 comment · Fixed by #34218
Closed

CI net472 leg failure: 'Target frameworks need to be updated' #34216

maryamariyan opened this issue Mar 27, 2020 · 1 comment · Fixed by #34218
Assignees
@maryamariyan
Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner

Comments

@maryamariyan
Copy link
Member

maryamariyan commented Mar 27, 2020 •
edited
Loading 

src\libraries\Common\tests\Extensions\TestingUtils\Microsoft.AspNetCore.Testing\src\xunit\FrameworkSkipConditionAttribute.cs(53,8): error CS1029: (NETCORE_ENGINEERING_TELEMETRY=Build) #error: 'Target frameworks need to be updated.'

https://github.com/dotnet/runtime/pull/34207/checks?check_run_id=540330536
@maryamariyan maryamariyan self-assigned this Mar 27, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 27, 2020
This was referenced Mar 27, 2020
Merged
Merged
Merged
@danmoseley
Copy link
Member

danmoseley commented Mar 28, 2020 •
edited
Loading

Thanks. In future, if you know the build is broken, and it is sometimes the best move to validate locally and direct-commit right after you throw up the PR (so the PR can complete validation, but you've already almost surely fixed it for everyone else)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maryamariyan maryamariyan

Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing net472 CI leg failure maryamariyan/runtime
3 participants
@maryamariyan @danmoseley @Dotnet-GitSync-Bot