Fixing net472 CI leg failure #34218
Merged
Fixing net472 CI leg failure #34218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Mar 27, 2020
|
this break got through because it's not a leg run in gated checkin? |
|
I had enabled the Configuration.Xml tests in this PR: #34174 and it was completely green. So I don't know why it didnt show up earlier. But today I noticed this failure on other open PRs and hence pushed up this fix. |
|
If it's currently breaking the build of other PR's, I suggest to just hit merge if you've verified locally. |
|
In this simple case |
|
Merging as it already went green for |
maryamariyan
added
area-Extensions-Configuration
and removed
area-Microsoft.Extensions
labels
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameworkSkipConditionAttribute.csis used in Configuration.Xml tests: https://github.com/dotnet/runtime/blob/master/src/libraries/Microsoft.Extensions.Configuration.Xml/tests/Microsoft.Extensions.Configuration.Xml.Tests.csproj#L21-L23This PR fixes CI leg failure for netfx:
https://github.com/dotnet/runtime/pull/34207/checks?check_run_id=540330536
Fixes: #34216