Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete task code that has been moved to the shared framework SDK in Arcade #34907

Closed
dagood opened this issue Apr 13, 2020 · 2 comments
Closed

Delete task code that has been moved to the shared framework SDK in Arcade #34907

dagood opened this issue Apr 13, 2020 · 2 comments
Assignees
@v-chayan
Labels
area-Infrastructure-installer
Milestone
5.0.0

Comments

@dagood
Copy link
Member

dagood commented Apr 13, 2020

This copy of CreateFrameworkListFile is unused and should be deleted:

https://github.com/dotnet/runtime/blob/59a24e5/tools-local/tasks/installer.tasks/CreateFrameworkListFile.cs

True source:

https://github.com/dotnet/arcade/blob/8935804/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/src/CreateFrameworkListFile.cs

Any other leftover copies of tasks from the sharedfx SDK should be removed too.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 13, 2020
@dagood dagood mentioned this issue Apr 13, 2020
Merged
@NikolaMilosavljevic NikolaMilosavljevic removed the untriaged New issue has not been triaged by the area owner label Apr 15, 2020
@NikolaMilosavljevic NikolaMilosavljevic self-assigned this Apr 15, 2020
@v-chayan v-chayan self-assigned this Apr 21, 2020
@v-chayan v-chayan mentioned this issue Apr 24, 2020
Merged
@NikolaMilosavljevic NikolaMilosavljevic added this to the 5.0.0 milestone Jul 8, 2020
@NikolaMilosavljevic NikolaMilosavljevic removed their assignment Jul 8, 2020
@NikolaMilosavljevic
Copy link
Member

@v-chayan can you validate that this is fixed and close?

@v-chayan
Copy link
Contributor

v-chayan commented Jul 9, 2020

Verified and close this issue.

@v-chayan v-chayan closed this as completed Jul 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@v-chayan v-chayan

Labels
area-Infrastructure-installer
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@NikolaMilosavljevic @dagood @v-chayan @Dotnet-GitSync-Bot