Creating a runtime pack artifacts directory in the libraries build #34662

mdh1418 · 2020-04-07T22:48:29Z

This PR looks to create a runtime package in the artifacts/bin directory through the libraries build process for the purpose testing the mobile apps (iOS and Android).

The desired directory hierarchy is as follows

- lib-runtime-packs
    - data
    - runtimes
       - <RID>
          - lib
             - <netcoreapp5.0>
          - native
             - include
             - cross

ghost · 2020-04-07T22:48:34Z

Tagging @ViktorHofer as an area owner

steveisok · 2020-04-07T23:24:47Z

https://github.com/dotnet/runtime/blob/c8e70b38302b5e8e9f176b2cce7e75ed5c0e86af/src/libraries/Directory.Build.props#L315-L317

We should follow this model and set something like:

<BinPlaceTestRuntimePack Condition="'$(BuildTargetFramework)' == '$(NetCoreAppCurrent)' and '$(TargetOS)' == 'iOS'">true</BinPlaceTestRuntimePack>

src/libraries/Directory.Build.props

src/libraries/Native/native-binplace.proj

src/libraries/Directory.Build.props

src/libraries/Directory.Build.targets

src/libraries/Native/native-binplace.proj

src/libraries/pretest.proj

src/libraries/Directory.Build.props

src/libraries/Native/native-binplace.proj

src/libraries/pretest.proj

src/libraries/restore/runtime/runtime.depproj

dagood · 2020-04-13T17:32:45Z

src/libraries/pretest.proj

@@ -2,6 +2,8 @@

  <PropertyGroup>
    <TraversalGlobalProperties>BuildAllProjects=true</TraversalGlobalProperties>
+    <NETCoreAppFrameworkIdentifier>.NETCoreApp</NETCoreAppFrameworkIdentifier>
+    <SharedFrameworkName>Microsoft.NETCore.App</SharedFrameworkName>


Share values with installer project tree? (Move to common ancestor?)

Where would be a good place to place these properties in <runtimeroot>/src/Directory.Build.props?
Is it a significant impact to performance/organization to move it up? I'm not familiar enough to know now if those properties have a chance of changing or differing between the directories in <runtimeroot>/src. If they were to differ later would it be better to have each specify their own properties?

It might not be worth it. My knee-jerk reaction is that duplicating code is what needs justification rather than reusing it, so just a quick suggestion.

Let's open an issue for this. Consolidate all places in props and targets where we use Microsoft.NETCore.App to a single shared property.

…ibraries

…d remove exclusion in runtime.depproj

src/libraries/Native/native-binplace.proj

jaredpar · 2020-04-14T18:46:34Z

src/libraries/restore/runtime/runtime.depproj

@@ -73,6 +70,20 @@
    <Exec Command="chmod +x $(TestHostRootPath)%(DotnetExe.Filename)%(DotnetExe.Extension)" Condition="'$(TargetOS)' != 'Windows_NT' and '$(OS)' != 'Windows_NT'"/>
  </Target>

+  <Target Name="SetupRuntimePackNative"


Given this target is specific to Mono should we include Mono in the target name?

there are going to be some differences with desktop mono, so I'd like to address them in a separate PR.

Do you have an issue tracking this work we can reference here?

src/libraries/restore/runtime/runtime.depproj

ViktorHofer · 2020-04-15T17:38:06Z

src/libraries/pretest.proj


  <PropertyGroup>
    <TraversalGlobalProperties>BuildAllProjects=true</TraversalGlobalProperties>
+    <NETCoreAppFrameworkIdentifier>$(NETCoreAppFrameworkIdentifier)</NETCoreAppFrameworkIdentifier>


Where is that property NETCoreAppFrameworkIdentifier defined in libraries? I don't see it anywhere. I was suggesting to use TargetFrameworkIdentifier which should contain the right value here but I might be wrong (if this project doesn't have a target framework set).

I would move the already defined property in installer into Configurations.props: https://github.com/dotnet/runtime/blob/master/eng/Configurations.props#L25 as it then will be available here as well.

Ah, I also didn't find it in libraries, but I saw that it was used in
<FrameworkListRootAttributes Include="TargetFrameworkIdentifier" Value="$(NETCoreAppFrameworkIdentifier)" />
and I accidentally picked the wrong one. changing to TargetFrameworkIdentifier

….proj

…e condition up

safern · 2020-04-15T20:41:09Z

src/libraries/pretest.proj

@@ -1,7 +1,11 @@
 <Project Sdk="Microsoft.Build.Traversal">
+  <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk" />
+  <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk" />


The targets are usually imported at the end of the file.

safern

LGTM.

I left an additional comment. The Sdk.targets in pretest.proj should be imported at the end.

Also, let's open an issue to consolidate Microsoft.NETCore.App usage in our props and targets to share the same property.

I think it is worth opening an issue to cleanup the TargetOS == iOS or ... conditions to use TargetsMobile == true.

safern · 2020-04-15T20:51:10Z

src/libraries/pretest.proj

@@ -94,4 +91,7 @@
      TargetFilePrefixes="ref/;runtimes/"
      RootAttributes="@(FrameworkListRootAttributes)" />
  </Target>
+
+  <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk" />


The props go at the top of the file, the targets at the end 😄

ohh oops, thanks!

steveisok · 2020-04-16T12:49:46Z

The 2 remaining lanes seem stuck. All the lanes that this change impacts have passed, so merging.

jaredpar · 2020-04-16T14:52:03Z

@steveisok

The 2 remaining lanes seem stuck.

This should not be a reason for merging. This should be a reason to ping the infra team to look into the issue.

In the last few days we've had a series of PRs merged without full validation. We're also running at 0% passing in CI. These are completely related items.

akoeplinger · 2020-04-16T14:59:31Z

@jaredpar there was already a Teams thread going on about this and https://github.com/dotnet/core-eng/issues/9630 is tracking it.

Dotnet-GitSync-Bot added the area-Infrastructure label Apr 7, 2020

mdh1418 requested a review from steveisok April 7, 2020 22:48

steveisok changed the title ~~[WIP] Creating Testing Package for mobile apps~~ [WIP] Creating a runtime pack artifacts directory in the libraries build Apr 7, 2020

steveisok reviewed Apr 7, 2020

View reviewed changes

src/libraries/Directory.Build.props Outdated Show resolved Hide resolved

steveisok reviewed Apr 7, 2020

View reviewed changes

src/libraries/Native/native-binplace.proj Outdated Show resolved Hide resolved

mdh1418 force-pushed the mdhwang/create_package_testing_folder branch 2 times, most recently from 42a7587 to b17e35d Compare April 8, 2020 15:56

riarenas mentioned this pull request Apr 8, 2020

Failures to restore from Azure artifacts feeds due to throttling dotnet/arcade#4190

Closed

jaredpar mentioned this pull request Apr 8, 2020

Errors installing the SDK during builds #34015

Closed

mdh1418 and others added 6 commits April 10, 2020 15:08

[libraries] Clean up SetupTestingHost

8321dea

[libraries] Setup runtime pack artifacts directory

be068f2

WIP havent addressed feedback or finished cleaning up

d22cee8

Fixed up some xml

e432bbc

[libraries] Set and use BinPlaceTestRuntimePack property

002b96b

Updates to structure. Build for ios now generates the right things

c3ba797

steveisok force-pushed the mdhwang/create_package_testing_folder branch from b17e35d to c3ba797 Compare April 10, 2020 19:50

akoeplinger reviewed Apr 13, 2020

View reviewed changes

Steve Pfister added 2 commits April 13, 2020 11:41

Feedback items

4d91c78

Removed targetOS check

94a03ab

steveisok changed the title ~~[WIP] Creating a runtime pack artifacts directory in the libraries build~~ Creating a runtime pack artifacts directory in the libraries build Apr 13, 2020

steveisok requested review from dagood and a team April 13, 2020 16:11

steveisok mentioned this pull request Apr 13, 2020

[mono] Add iOS app builder project #34563

Merged

dagood reviewed Apr 13, 2020

View reviewed changes

dagood requested a review from NikolaMilosavljevic April 13, 2020 17:33

[libraries] Address feedback

3cafc0f

mdh1418 force-pushed the mdhwang/create_package_testing_folder branch from 86833e0 to 3cafc0f Compare April 13, 2020 20:19

[libraries] Add DotNetBuildTasksSharedFrameworkTaskFile property to l…

d71ddd1

…ibraries

mdh1418 added 2 commits April 14, 2020 13:47

[libraries] Remove superfluous condition

d465796

[libraries] Condition BinPlaceNETFXRuntime on not targeting mobile an…

60b9009

…d remove exclusion in runtime.depproj

mdh1418 force-pushed the mdhwang/create_package_testing_folder branch from 3ea474a to 0c650a3 Compare April 14, 2020 18:16

jaredpar reviewed Apr 14, 2020

View reviewed changes

mdh1418 force-pushed the mdhwang/create_package_testing_folder branch from 5920234 to fe67b95 Compare April 15, 2020 15:10

safern reviewed Apr 15, 2020

View reviewed changes

src/libraries/restore/runtime/runtime.depproj Outdated Show resolved Hide resolved

safern reviewed Apr 15, 2020

View reviewed changes

src/libraries/restore/runtime/runtime.depproj Outdated Show resolved Hide resolved

ViktorHofer reviewed Apr 15, 2020

View reviewed changes

mdh1418 added 6 commits April 15, 2020 13:43

[libraries] Remove hardcoded NETCoreAppFrameworkIdentifier in pretest…

23da306

….proj

[libraries] Import Sdk.targets into pretest.proj as well

211eece

[libraries] Reduce Copy usage in runtime.depproj

2d4d7f4

[libraries] Exclude unwanted files from runtime packs

757c871

[libraries] Change to singular NativeBinPlaceItem

bc3991a

[libraries] Consolidate itemgroups in runtime.depproj and move runtim…

ba6d021

…e condition up

mdh1418 force-pushed the mdhwang/create_package_testing_folder branch from 9dcf2f4 to ba6d021 Compare April 15, 2020 17:43

safern reviewed Apr 15, 2020

View reviewed changes

safern approved these changes Apr 15, 2020

View reviewed changes

safern reviewed Apr 15, 2020

View reviewed changes

[libraries] Move pretest.proj imports to end of the file

0d46895

mdh1418 force-pushed the mdhwang/create_package_testing_folder branch from 405b950 to 0d46895 Compare April 15, 2020 20:52

steveisok mentioned this pull request Apr 15, 2020

Follow up task for in-tree runtime pack work #35023

Closed

2 tasks

steveisok merged commit c991d9b into dotnet:master Apr 16, 2020

mdh1418 mentioned this pull request Apr 17, 2020

Mdhwang/reduce mobile checks #35105

Merged

mdh1418 deleted the mdhwang/create_package_testing_folder branch April 17, 2020 15:37

mdh1418 mentioned this pull request Apr 17, 2020

Consolidate Microsoft.NETCore.App property usage #35116

Merged

ghost locked as resolved and limited conversation to collaborators Dec 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creating a runtime pack artifacts directory in the libraries build #34662

Creating a runtime pack artifacts directory in the libraries build #34662

mdh1418 commented Apr 7, 2020 •

edited by steveisok

Loading

ghost commented Apr 7, 2020

steveisok commented Apr 7, 2020

dagood Apr 13, 2020

mdh1418 Apr 13, 2020

dagood Apr 13, 2020

safern Apr 15, 2020

jaredpar Apr 14, 2020

steveisok Apr 14, 2020

jaredpar Apr 14, 2020

steveisok Apr 14, 2020

ViktorHofer Apr 15, 2020

ViktorHofer Apr 15, 2020

mdh1418 Apr 15, 2020

safern Apr 15, 2020

safern left a comment

safern Apr 15, 2020

mdh1418 Apr 15, 2020

steveisok commented Apr 16, 2020

jaredpar commented Apr 16, 2020

akoeplinger commented Apr 16, 2020

Creating a runtime pack artifacts directory in the libraries build #34662

Creating a runtime pack artifacts directory in the libraries build #34662

Conversation

mdh1418 commented Apr 7, 2020 • edited by steveisok Loading

ghost commented Apr 7, 2020

steveisok commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

safern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveisok commented Apr 16, 2020

jaredpar commented Apr 16, 2020

akoeplinger commented Apr 16, 2020

mdh1418 commented Apr 7, 2020 •

edited by steveisok

Loading