Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceFromRuntime aren't resolvable inside VS if the default runtime configuration hasn't been built #36464

Closed
ViktorHofer opened this issue May 14, 2020 · 3 comments · Fixed by #38196
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@ViktorHofer
Copy link
Member

Following up on the discussion here: #36126 (comment).

My recommendation is to get rid of ReferenceFromRuntime items that point to CoreLib and replace them with P2Ps. The P2P would either point to coreclr's or mono's CoreLib.

cc @safern @ericstj @GrabYourPitchforks

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ericstj
Copy link
Member

ericstj commented May 14, 2020

To make P2P work CoreLib would have to state all its TargetFrameworks and cross-compile by those and not rely on any global properties from a vertical build to determine its content. Is that what you had in mind @ViktorHofer?

@safern
Copy link
Member

safern commented May 14, 2020

Related issue: #34653

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants