Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a ProjectReference to reference System.Private.CoreLib from libraries #37963

Closed
ViktorHofer opened this issue Jun 16, 2020 · 1 comment · Fixed by #38196
Closed

Use a ProjectReference to reference System.Private.CoreLib from libraries #37963

ViktorHofer opened this issue Jun 16, 2020 · 1 comment · Fixed by #38196
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 16, 2020 •
edited
Loading

Today we are using ReferenceFromRuntime items to reference System.Private.CoreLib. This requires the developer to specify the RuntimeConfiguration when building the product and even when building test projects.

We could leverage the TargetFramework.Sdk for System.Private.CoreLib to multiplex on different OSs as we do for libraries projects or avoid that by making sure that S.P.CoreLib's surface area is identical for different OSs (which AFAIK should be case now with the WinRT removal).

This is high on our developer productivity radar as developers need to build the clr.corelib subset today explicitly before being able to build the libraries source projects.

Related: #36464

cc @ericstj @safern @Anipik
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Jun 16, 2020
@ghost
Copy link

ghost commented Jun 16, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

This was referenced Jun 17, 2020
Open
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ProjectReference to build against System.Private.CoreLib ViktorHofer/runtime
2 participants
@ViktorHofer @Dotnet-GitSync-Bot