CompareInfoIsSuffixTests.IsSuffix fails on Android

[steveisok]

This test fails on every arch with:

Assert.Equal() Failure
Expected: False
Actual:   True

StackTrace:

at System.Globalization.Tests.CompareInfoIsSuffixTests.IsSuffix(CompareInfo compareInfo, String source, String value, CompareOptions options, Boolean expected) in /Users/steve/dev/net5/droid-runtime/src/libraries/System.Globalization/tests/CompareInfo/CompareInfoTests.IsSuffix.cs:line 103
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /Users/steve/dev/net5/droid-runtime/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 359

[ghost]

Tagging subscribers to this area: @tarekgh, @safern, @krwq
Notify danmosemsft if you want to be subscribed.

[safern]

Thanks @steveisok for opening these issues. Given the number of tests and test suites we have would it make sense to open a meta issue per test assembly for each platform listing the individual tests and then we can close the issue once the test suite is green with no ActiveIssue against that issue?

[GrabYourPitchforks]

Echoing Santi, I'd also prefer a single issue per assembly. Otherwise we run the risk of drowning out other issues in the repo.

Is there a particular CI output where we can see the failures? I pulled a random recent PR (#36633) and it seems like the Android CI legs are passing. Seeing the exact CI failures will help pinpoint what inputs were fed into these test theories at the time they failed.

[safern]

it seems like the Android CI legs are passing. Seeing the exact CI failures will help pinpoint what inputs were fed into these test theories at the time they failed.

We’re not yet running tests on CI. We’re on the process on enabling that and we’ve been running them locally and gathering numbers in order to disable against issues and add a leg.

[tarekgh]

@steveisok if you don't mind, we'll consolidate the issues to be one issue per test suite. that is even will be easier for tracking and ensuring the whole suite is fixed.

@safern could you please go ahead and consolidate those?

[tarekgh]

by the way, do we now use ICU on Android? or this work still in progress?

[tarekgh]

#36630
#36629
#36628
#36627
#36626
#36625
#36624

[safern]

@safern could you please go ahead and consolidate those?

Yeah I’ll take care of it.

[safern]

Closing in favor of: #36672

[safern]

by the way, do we now use ICU on Android?

I believe we use the one that ships as part of Android but I might be miss remembering, @akoeplinger should know better.

[akoeplinger]

Yes we use the ICU that is part of the Android system right now.