Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Globalization.Tests fail on Android #36672

Closed
13 tasks done
safern opened this issue May 18, 2020 · 3 comments · Fixed by #56147
Closed
13 tasks done

System.Globalization.Tests fail on Android #36672

safern opened this issue May 18, 2020 · 3 comments · Fixed by #56147
Labels
area-System.Globalization os-android test-run-core Test failures in .NET Core test runs
Milestone
6.0.0

Comments

@safern
Copy link
Member

safern commented May 18, 2020 •
edited by steveisok
Loading

Various tests from System.Globalization.Tests fail on Android:

  • CompareInfoCompareTests.Compare
  • TextInfoMiscTests.ToUpper
  • TextInfoMiscTests.ToLower
  • CompareInfoIsSuffixTests.IsSuffix
  • CompareInfoIsPrefixTests.IsPrefix
  • CompareInfoLastIndexOfTests.LastIndexOf_String
  • CompareInfoIndexOfTests.IndexOf_String
  • CompareInfoTests.SortKeyTest
  • CultureInfoEnglishName.EnglishName
  • RegionInfoPropertyTests.MiscTest
  • RegionInfoPropertyTests.NativeName
  • RegionInfoPropertyTests.EnglishName
  • CultureInfoNativeName.NativeName

Note that more tests might be shown as failed (in testResults.xml) now because of SkipTestException thrown in RemoteExecutor, we need support from the runner to treat those tests as skipped: dotnet/xharness#205

Stack traces
System.Globalization.Methods_and_Stack_traces.txt

Edit: Updated based on #50095

System.Globalization.Tests.log
@safern safern added area-System.Globalization test-run-core Test failures in .NET Core test runs os-android labels May 18, 2020
@ghost
Copy link

ghost commented May 18, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 18, 2020
@safern safern mentioned this issue May 18, 2020
Closed
@safern safern removed the untriaged New issue has not been triaged by the area owner label May 18, 2020
This was referenced May 18, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tarekgh tarekgh added this to the 5.0 milestone May 18, 2020
@GrabYourPitchforks
Copy link
Member

We'd need to know what inputs are causing the failures, along with how we can get the CI logs from the failures. Current PR legs are not failing, so this issue is at the moment not actionable by the team.

@safern
Copy link
Member Author

safern commented May 19, 2020

@GrabYourPitchforks we don’t have them running on CI yet. This issue is to track progress of adding these legs to CI and to be able to disable the tests agains the issue. There is no action required by anyone but the crew working on the mobile effort.

@safern safern mentioned this issue May 27, 2020
Closed
1 task
@danmoseley danmoseley modified the milestones: 5.0.0, 6.0.0 Jun 16, 2020
@marek-safar marek-safar added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jun 24, 2020
@marek-safar marek-safar mentioned this issue Feb 25, 2021
Closed
3 tasks
steveisok pushed a commit to steveisok/runtime that referenced this issue Jul 22, 2021
Reenable some Android Globalization tests
f8b3d9b 
Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures.  This change skips the data items that do have difficulty.

Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop.  Adjusted accordingly.

Fixes dotnet#36672
@steveisok steveisok mentioned this issue Jul 22, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 22, 2021
steveisok added a commit that referenced this issue Jul 23, 2021
@steveisok
Reenable some Android Globalization tests (#56147)
4e47e8c 
Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.

Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.

Fixes #36672
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Globalization os-android test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Reenable some Android Globalization tests steveisok/runtime
6 participants
@marek-safar @GrabYourPitchforks @danmoseley @tarekgh @safern @Dotnet-GitSync-Bot