Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunGetBitLengthTests unit test failing on wasm #38605

Closed
GrabYourPitchforks opened this issue Jun 30, 2020 · 4 comments · Fixed by #38613
Closed

RunGetBitLengthTests unit test failing on wasm #38605

GrabYourPitchforks opened this issue Jun 30, 2020 · 4 comments · Fixed by #38613
Labels
arch-wasm WebAssembly architecture area-System.Numerics blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-run-core Test failures in .NET Core test runs
Milestone
5.0.0

Comments

@GrabYourPitchforks
Copy link
Member

Project System.Runtime.Numerics.Tests, test GetBitLengthTests.RunGetBitLengthTests is causing CI to fail across all PRs due to an OOM.

See https://helix.dot.net/api/2019-06-17/jobs/c91e6e61-3788-4c7f-b09b-5c092f9dc99b/workitems/System.Runtime.Numerics.Tests/console for one example of a failure.

[05:12:11] dbug: test[0]
      [FAIL] System.Numerics.Tests.GetBitLengthTests.RunGetBitLengthTests
      
[05:12:11] dbug: test[0]
      System.OutOfMemoryException : Out of memory
@GrabYourPitchforks GrabYourPitchforks added area-System.Numerics blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Jun 30, 2020
@GrabYourPitchforks GrabYourPitchforks added this to the 5.0.0 milestone Jun 30, 2020
@ghost
Copy link

ghost commented Jun 30, 2020

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 30, 2020
@GrabYourPitchforks GrabYourPitchforks added arch-wasm WebAssembly architecture test-run-core Test failures in .NET Core test runs labels Jun 30, 2020
@GrabYourPitchforks GrabYourPitchforks mentioned this issue Jun 30, 2020
Merged
@marek-safar
Copy link
Contributor

/cc @BrzVlad

@ManickaP
Copy link
Member

Hit in #38453 AzDO

@akoeplinger
Copy link
Member

These tests are testing large BigInteger cases:

runtime/src/libraries/System.Runtime.Numerics/tests/BigInteger/GetBitLengthTests.cs

Lines 41 to 43 in 2e1bab1

// Very large cases
VerifyGetBitLength(BigInteger.One << 32 << int.MaxValue, int.MaxValue + 32L + 1, 1);
VerifyGetBitLength(BigInteger.One << 64 << int.MaxValue, int.MaxValue + 64L + 1, 1);

Maybe we should disable them on Browser?

@BrzVlad BrzVlad mentioned this issue Jun 30, 2020
Merged
@vitek-karas vitek-karas mentioned this issue Jun 30, 2020
Merged
@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label Sep 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Numerics blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] Disable test on browser BrzVlad/runtime
6 participants
@marek-safar @akoeplinger @GrabYourPitchforks @tannergooding @ManickaP @Dotnet-GitSync-Bot