Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging of PDBs for host binaries #38589

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

elinor-fung
Copy link
Member

Resolves #38587

After #33716, the PDBs for host binaries are installed to subdirectory instead of right next to the binaries themselves. As a result, they were no longer being put into the symbols packages.

@ghost
Copy link

ghost commented Jun 30, 2020

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar, @agocke
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented Jun 30, 2020

Hello @elinor-fung!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@vitek-karas
Copy link
Member

The failing WASM test log is:

[05:45:27] dbug: test[0]
      [FAIL] System.Numerics.Tests.GetBitLengthTests.RunGetBitLengthTests
      
[05:45:27] dbug: test[0]
      System.OutOfMemoryException : Out of memory
      
[05:45:27] dbug: test[0]
         at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@vitek-karas
Copy link
Member

The CI failure is known and unrelated #38605.

@elinor-fung elinor-fung merged commit 60ca9da into dotnet:master Jun 30, 2020
@elinor-fung elinor-fung deleted the hostSymbols branch June 30, 2020 17:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbols for host binaries are not published to public symbol server
4 participants