Type.IsInterface returns different values between .NET and Mono for byref types #39068

rolfbjarne · 2020-07-10T12:05:09Z

Description

Test case:

interface I {}

Console.WriteLine (typeof (I).MakeByRefType ().IsInterface);

shows True with Mono and False with .NET (on macOS using .NET Core using MonoVM).

Complete test case: consoleapp-fbd84e3.zip

Download, unzip, and run make both:

 $ make both
Mono output:
    I& IsInterface: True
.NET output:
    I& IsInterface: False

Configuration

$ dotnet --version
5.0.100-preview.7.20317.11

What OS and version, and what distro if applicable?

macOS 10.15

The text was updated successfully, but these errors were encountered:

Dotnet-GitSync-Bot · 2020-07-10T12:05:13Z

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

…n't work the same for byref types. Ref: dotnet/runtime#39068

… doesn't work the same for byref types. Ref: dotnet/runtime#39068

… doesn't work the same way for byref types. Ref: dotnet/runtime#39068 Fixes this test: MonoTouchFixtures.ObjCRuntime.RegistrarTest [FAIL] RefOutTest_INSCoding : System.InvalidCastException : Unable to cast object of type 'Foundation.NSString' to type 'Foundation.INSCoding&'. at ObjCRuntime.Runtime.GetINativeObject(IntPtr ptr, Boolean owns, Type target_type, Type implementation) at ObjCRuntime.Runtime.GetINativeObject(IntPtr ptr, Boolean owns, Type target_type) at ObjCRuntime.Runtime.GetINativeObject_Dynamic(IntPtr ptr, Boolean owns, IntPtr type_ptr) at ObjCRuntime.Runtime.get_inative_object_dynamic(IntPtr obj, Boolean owns, IntPtr type, Int32& exception_gchandle) --- End of stack trace from previous location --- at MonoTouchFixtures.ObjCRuntime.RegistrarTest.RefOutTest_INSCoding() in /Users/rolf/work/maccore/squashed-onedotnet/xamarin-macios/tests/monotouch-test/ObjCRuntime/RegistrarTest.cs:line 2908 at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

… doesn't work the same way for byref types. (#9466) Ref: dotnet/runtime#39068 Fixes this test: MonoTouchFixtures.ObjCRuntime.RegistrarTest [FAIL] RefOutTest_INSCoding : System.InvalidCastException : Unable to cast object of type 'Foundation.NSString' to type 'Foundation.INSCoding&'. at ObjCRuntime.Runtime.GetINativeObject(IntPtr ptr, Boolean owns, Type target_type, Type implementation) at ObjCRuntime.Runtime.GetINativeObject(IntPtr ptr, Boolean owns, Type target_type) at ObjCRuntime.Runtime.GetINativeObject_Dynamic(IntPtr ptr, Boolean owns, IntPtr type_ptr) at ObjCRuntime.Runtime.get_inative_object_dynamic(IntPtr obj, Boolean owns, IntPtr type, Int32& exception_gchandle) --- End of stack trace from previous location --- at MonoTouchFixtures.ObjCRuntime.RegistrarTest.RefOutTest_INSCoding() in /Users/rolf/work/maccore/squashed-onedotnet/xamarin-macios/tests/monotouch-test/ObjCRuntime/RegistrarTest.cs:line 2908 at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

marek-safar · 2020-10-10T11:58:32Z

@lambdageek could you investigate what broke?

lambdageek · 2020-10-13T20:07:59Z

There's no bug in the netcore version of Mono. Its output matches CoreCLR (and also .NET Framework, FWIW).

The outlier is Mono 6.* from https://github.com/mono/mono which prints True while all the rest print False.

If we want to fix this in mono/mono, I'll move the bug there.

lambdageek · 2020-10-13T20:09:02Z

The issue btw, is this code. Non-netcore Mono would need to do the byref check, too.

runtime/src/mono/mono/metadata/icall.c

Lines 2178 to 2189 in ce51448

    
           ves_icall_RuntimeTypeHandle_GetAttributes (MonoReflectionTypeHandle ref_type, MonoError *error) 
        
           { 
        
           	MonoType *type = MONO_HANDLE_GETVAL (ref_type, type); 
        
           #ifdef ENABLE_NETCORE 
        
           	if (type->byref || type->type == MONO_TYPE_PTR || type->type == MONO_TYPE_FNPTR) 
        
           		return TYPE_ATTRIBUTE_NOT_PUBLIC; 
        
           #endif 
        
           	MonoClass *klass = mono_class_from_mono_type_internal (type); 
        
           	return mono_class_get_flags (klass); 
        
           }

marek-safar · 2020-10-14T06:48:20Z

Closing as by-design

Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 10, 2020

rolfbjarne mentioned this issue Jul 10, 2020

[.NET 6] External dotnet issues xamarin/xamarin-macios#8901

Closed

61 tasks

jkotas changed the title ~~Type.IsInterface returns different values between .NET and Mono for reference types~~ Type.IsInterface returns different values between .NET and Mono for byref types Jul 10, 2020

jkotas added the area-VM-meta-mono label Jul 10, 2020

marek-safar removed the untriaged New issue has not been triaged by the area owner label Jul 13, 2020

marek-safar added this to the 6.0.0 milestone Jul 13, 2020

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 4, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

998ecdf

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 5, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

a178c0c

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 5, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

ec9c846

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 6, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

9f9659d

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 7, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

8c3f941

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 7, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

d96bd75

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 7, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

7310e46

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 7, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

71f14b8

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 10, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

45d3b7e

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 14, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

57f2209

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 18, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

3d5beac

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 18, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

b78baad

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 19, 2020

[ObjCRuntime] Work around a difference in .NET where IsInterface does…

40f03eb

…n't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 19, 2020

[ObjCRuntime] Work around a difference in .NET where Type.IsInterface…

90338a1

… doesn't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 20, 2020

[ObjCRuntime] Work around a difference in .NET where Type.IsInterface…

c863986

… doesn't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 21, 2020

[ObjCRuntime] Work around a difference in .NET where Type.IsInterface…

6ac6cd3

… doesn't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 24, 2020

[ObjCRuntime] Work around a difference in .NET where Type.IsInterface…

43730f9

… doesn't work the same for byref types. Ref: dotnet/runtime#39068

rolfbjarne mentioned this issue Aug 24, 2020

[ObjCRuntime] Work around a difference in .NET where Type.IsInterface doesn't work the same way for byref types. xamarin/xamarin-macios#9466

Merged

marek-safar closed this as completed Oct 14, 2020

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Type.IsInterface returns different values between .NET and Mono for byref types #39068

Type.IsInterface returns different values between .NET and Mono for byref types #39068

rolfbjarne commented Jul 10, 2020

Dotnet-GitSync-Bot commented Jul 10, 2020

marek-safar commented Oct 10, 2020

lambdageek commented Oct 13, 2020

lambdageek commented Oct 13, 2020

marek-safar commented Oct 14, 2020

Type.IsInterface returns different values between .NET and Mono for byref types #39068

Type.IsInterface returns different values between .NET and Mono for byref types #39068

Comments

rolfbjarne commented Jul 10, 2020

Description

Configuration

Dotnet-GitSync-Bot commented Jul 10, 2020

marek-safar commented Oct 10, 2020

lambdageek commented Oct 13, 2020

lambdageek commented Oct 13, 2020

marek-safar commented Oct 14, 2020