Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: Microsoft.Extensions.Caching.Memory.CapacityTests.DoNotAddIfSizeOverflows #39241

Closed
BruceForstall opened this issue Jul 14, 2020 · 6 comments
Labels
arch-x86 area-Extensions-Caching JitStress CLR JIT issues involving JIT internal stress modes os-windows
Milestone

Comments

@BruceForstall
Copy link
Member

Windows, x86, COMPlus_JitStressRegs=8

https://dev.azure.com/dnceng/public/_build/results?buildId=726304&view=ms.vss-test-web.build-test-results-tab&runId=22490824&resultId=102068&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

I don't think this is related to JitStressRegs; I can't repro it locally like that. I think the test simply fails sometimes on loaded systems due to this code:

            // Wait for compaction to complete
            Assert.True(await sem.WaitAsync(TimeSpan.FromSeconds(10)));

Kusto shows 6 such failures in the last 30 days (all Windows x86, JitStress).

Could this timeout number be made much, much higher?

@BruceForstall BruceForstall added arch-x86 os-windows JitStress CLR JIT issues involving JIT internal stress modes area-Microsoft.Extensions labels Jul 14, 2020
@danmoseley
Copy link
Member

Increasing the timeout would not affect tests that pass today, right? I think it would be fine if you want to increase those numbers.

@BruceForstall
Copy link
Member Author

Increasing the timeout would not affect tests that pass today, right?

No idea. That would be up to the test owner to determine.

I think it would be fine if you want to increase those numbers.

I would prefer the test/area owner make that change, to contribute to a better, more stable CI.

@ghost
Copy link

ghost commented Jul 16, 2020

Tagging subscribers to this area: @eerhardt, @maryamariyan
Notify danmosemsft if you want to be subscribed.

@maryamariyan maryamariyan added this to the Future milestone Jul 16, 2020
@BruceForstall
Copy link
Member Author

Dup'ing to #33993

BruceForstall added a commit to BruceForstall/runtime that referenced this issue Jul 26, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x86 area-Extensions-Caching JitStress CLR JIT issues involving JIT internal stress modes os-windows
Projects
None yet
Development

No branches or pull requests

4 participants