Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][filesystem] FileSystem test not passing due to working directory #39998

Closed
kjpou1 opened this issue Jul 28, 2020 · 0 comments · Fixed by #42020
Closed

[browser][filesystem] FileSystem test not passing due to working directory #39998

kjpou1 opened this issue Jul 28, 2020 · 0 comments · Fixed by #42020
Labels
arch-wasm WebAssembly architecture area-System.IO disabled-test The test is disabled in source code against the issue
Milestone
6.0.0

Comments

@kjpou1
Copy link
Contributor

kjpou1 commented Jul 28, 2020 •
edited
Loading

System.IO.Tests.DirectoryInfo_Name.CurrentDirectory does not pass because it is using Path.GetFileName on the current directory of "/".

		config.loaded_cb = function () {
			FS.mkdir("net5.0-Browser-debug");
			FS.chdir("net5.0-Browser-debug");
			App.init ();
		};

By setting the current directory as above the test passes. This should be set via command line args and the setup of the test harness.

Using this active issue for a temporary skipping of this test and flag for later.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Jul 28, 2020
@kjpou1 kjpou1 added the arch-wasm WebAssembly architecture label Jul 28, 2020
@marek-safar marek-safar added disabled-test The test is disabled in source code against the issue and removed untriaged New issue has not been triaged by the area owner labels Jul 31, 2020
@marek-safar marek-safar added this to the 6.0.0 milestone Jul 31, 2020
mdh1418 pushed a commit that referenced this issue Aug 10, 2020
@kjpou1 @jkotas
[browser][file system] Tests System.IO.FileSystem (#39768)
4dbe414 
* [browser][file system] Tests System.IO.FileSystem

* Remove FileSystem from test project exclusions.

* [browser][filesystem] Comment on skipped tests due to IO.Pipes not supported

* [browser][filesystem] Comment on skipped tests due to monitor not supported

* Address review comments

* Address review comments on how to handle monitor PNSE

* Update src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Add ActiveIssue for browser platform

```
        [ActiveIssue("#39955", TestPlatforms.Browser)]
        public void NotFoundErrorIsExpected()
```

* Simplify test case with `PlatformDetection.IsSuperUser` as per review comment

* Remove unused variable from tests

* Browser platform volume does not limit each component of the path to a total of 255 characters.

- Remove the test `DirectoryWithComponentLongerThanMaxComponentAsPath_ThrowsException` for Browser platform.
- Add new test `DirectoryWithComponentLongerThanMaxComponentAsPath_BrowserDoesNotThrowsException` for Browser platform in case this check is added in the future.

* Fix windows tests

* Add ActiveIssue to test System.IO.Tests.DirectoryInfo_Name.CurrentDirectory

- System.IO.Tests.DirectoryInfo_Name.CurrentDirectory does not pass because it is using Path.GetFileName on the current directory of "/".
- See issue #39998 for more information

* Add active issue for tests that need to support file locking.

* Add active issue for tests that need to support file locking.

* Browser volume does not have a limit on segments

* Remove browser platform test

* Remove active issue for NotFoundErrorIsExpected

* Remove platform specific from SkippingHiddenFiles

* Fix enumeration test errors failing from `HiddenFilesAreReturned`.

- WebAssembly (BROWSER) has dirent d_type but is not identifying correctly but by returning UNKNOWN the managed code properly stats the file to detect if entry is directory or not.

* Fix enumeration test errors failing from `HiddenFilesAreReturned`.

- WebAssembly (BROWSER) has dirent d_type but is not identifying correctly but by returning UNKNOWN the managed code properly stats the file to detect if entry is directory or not.

* Fix build for TARGET_WASM not defined

* Address review comment by add check for IsWindows to IsSuperUser.

* Address review comment by add check for IsWindows to IsSuperUser.

* Platform Specific test for hidden files no longer needed.

* Platform Specific test fno longer needed.

* Use active issue for rename issue

* ActiveIssue no longer needed

- PR #40310 works around the issue for now while waiting for fix emscripten-core/emscripten#11804 / emscripten-core/emscripten#11812

* Use ActiveIssue for SettingUpdatesProperties

* Use ActiveIssue for TimesIncludeMillisecondPart

* Use ActiveIssue for ErrorHandlingTests failures

* Use ActiveIssue for SetUptoNanoseconds

* Use ActiveIssue for GetSetTimes test failures

* Use ActiveIssue for tests failing with DirectoryNotFoundException

* Use ActiveIssue for tests failing with UnauthorizedAccessException

* Remove debugging statement from pal_io

* Address type in CreateDirectory method name

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
@tqiu8 tqiu8 mentioned this issue Sep 9, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.IO disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][filesystem] add arg to testharness for setting working dir tqiu8/runtime
3 participants
@marek-safar @kjpou1 @Dotnet-GitSync-Bot